Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: tracing/tracing/metrics/system_health/responsiveness_metric.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/responsiveness_metric.html
diff --git a/tracing/tracing/metrics/system_health/responsiveness_metric.html b/tracing/tracing/metrics/system_health/responsiveness_metric.html
index 45a2424b522153cec4123ba7988b675bdc2bf4e8..0f04b91029c90dfbfd7f28987898c59471d91002 100644
--- a/tracing/tracing/metrics/system_health/responsiveness_metric.html
+++ b/tracing/tracing/metrics/system_health/responsiveness_metric.html
@@ -91,7 +91,7 @@ tr.exportTo('tr.metrics.sh', function() {
} else if (ue instanceof tr.model.um.LoadExpectation) {
// This is already covered by loadingMetric.
} else if (ue instanceof tr.model.um.ResponseExpectation) {
- responseNumeric.add(ue.duration, sampleDiagnosticMap);
+ responseNumeric.addSample(ue.duration, sampleDiagnosticMap);
} else if (ue instanceof tr.model.um.AnimationExpectation) {
if (ue.frameEvents === undefined || ue.frameEvents.length === 0) {
// Ignore animation stages that do not have associated frames:
@@ -103,21 +103,21 @@ tr.exportTo('tr.metrics.sh', function() {
throw new Error('Missing throughput for ' +
ue.stableId);
- throughputNumeric.add(throughput, sampleDiagnosticMap);
+ throughputNumeric.addSample(throughput, sampleDiagnosticMap);
var frameTimeDiscrepancy = computeAnimationframeTimeDiscrepancy(ue);
if (frameTimeDiscrepancy === undefined)
throw new Error('Missing frameTimeDiscrepancy for ' +
ue.stableId);
- frameTimeDiscrepancyNumeric.add(frameTimeDiscrepancy,
- sampleDiagnosticMap);
+ frameTimeDiscrepancyNumeric.addSample(
+ frameTimeDiscrepancy, sampleDiagnosticMap);
ue.associatedEvents.forEach(function(event) {
if (!(event instanceof tr.e.cc.InputLatencyAsyncSlice))
return;
- latencyNumeric.add(event.duration, sampleDiagnosticMap);
+ latencyNumeric.addSample(event.duration, sampleDiagnosticMap);
});
} else {
throw new Error('Unrecognized stage for ' + ue.stableId);

Powered by Google App Engine
This is Rietveld 408576698