Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: tracing/tracing/value/value_set_test.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/ui/value_set_view_test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/value_set_test.html
diff --git a/tracing/tracing/value/value_set_test.html b/tracing/tracing/value/value_set_test.html
index ac8daad178f6ca34ef9263043bb1161f8de6f528..2768d02d71ac1421bda4718869a565fc0da92232 100644
--- a/tracing/tracing/value/value_set_test.html
+++ b/tracing/tracing/value/value_set_test.html
@@ -18,7 +18,7 @@ found in the LICENSE file.
tr.b.unittest.testSuite(function() {
test('addValuesFromDicts', function() {
var n = new tr.v.Histogram(tr.v.Unit.byName.unitlessNumber);
- n.add(10);
+ n.addSample(10);
n.customizeSummaryOptions({
count: true,
min: false,
@@ -38,9 +38,7 @@ tr.b.unittest.testSuite(function() {
test('addValueFromDictsWithSampleDiagnostic', function() {
var n = new tr.v.Histogram(tr.v.Unit.byName.count);
- n.add(10, tr.v.d.DiagnosticMap.fromObject({
- bar: new tr.v.d.Generic('baz')
- }));
+ n.addSample(10, {bar: new tr.v.d.Generic('baz')});
var values = new tr.v.ValueSet([new tr.v.NumericValue('foo', n)]);
var values2 = new tr.v.ValueSet();
@@ -58,9 +56,9 @@ tr.b.unittest.testSuite(function() {
var n = new tr.v.Histogram(tr.v.Unit.byName.unitlessNumber,
tr.v.HistogramBinBoundaries.createLinear(0, 100, 100));
- n.add(50);
- n.add(60);
- n.add(70);
+ n.addSample(50);
+ n.addSample(60);
+ n.addSample(70);
n.customizeSummaryOptions({
count: true,
@@ -219,12 +217,11 @@ tr.b.unittest.testSuite(function() {
test('sourceValuesWithSampleDiagnostic', function() {
var unit = tr.v.Unit.byName.unitlessNumber;
var aHist = new tr.v.Histogram(unit);
- aHist.add(1);
+ aHist.addSample(1);
var a = new tr.v.NumericValue('a', aHist);
var numeric = new tr.v.Histogram(tr.v.Unit.byName.unitlessNumber);
- numeric.add(1, tr.v.d.DiagnosticMap.fromObject({
- rvs: new tr.v.d.RelatedValueSet([a])}));
+ numeric.addSample(1, {rvs: new tr.v.d.RelatedValueSet([a])});
var b = new tr.v.NumericValue('b', numeric);
var values = new tr.v.ValueSet([a, b]);
« no previous file with comments | « tracing/tracing/value/ui/value_set_view_test.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698