Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: tracing/tracing/metrics/metric_registry_test.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/cpu_process_metric.html ('k') | tracing/tracing/metrics/sample_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/metric_registry_test.html
diff --git a/tracing/tracing/metrics/metric_registry_test.html b/tracing/tracing/metrics/metric_registry_test.html
index 715327c8ed06a28cc7833fdbacc19b11553f3dc4..14fda70442f7a60f861979b8c504e4108ab8a4a7 100644
--- a/tracing/tracing/metrics/metric_registry_test.html
+++ b/tracing/tracing/metrics/metric_registry_test.html
@@ -17,7 +17,7 @@ tr.b.unittest.testSuite(function() {
test('FindMetricByName', function() {
function sampleMetricA(values, model) {
var n1 = new tr.v.Histogram(tr.v.Unit.byName.count);
- n1.add(1);
+ n1.addSample(1);
values.addValue(new tr.v.NumericValue('foo', n1));
}
tr.metrics.MetricRegistry.register(sampleMetricA);
@@ -25,8 +25,8 @@ tr.b.unittest.testSuite(function() {
function sampleMetricB(values, model) {
var n1 = new tr.v.Histogram(tr.v.Unit.byName.count);
var n2 = new tr.v.Histogram(tr.v.Unit.byName.count);
- n1.add(1);
- n2.add(2);
+ n1.addSample(1);
+ n2.addSample(2);
values.addValue(new tr.v.NumericValue('foo', n1));
values.addValue(new tr.v.NumericValue('bar', n2));
}
@@ -36,9 +36,9 @@ tr.b.unittest.testSuite(function() {
var n1 = new tr.v.Histogram(tr.v.Unit.byName.count);
var n2 = new tr.v.Histogram(tr.v.Unit.byName.count);
var n3 = new tr.v.Histogram(tr.v.Unit.byName.count);
- n1.add(1);
- n2.add(2);
- n3.add(3);
+ n1.addSample(1);
+ n2.addSample(2);
+ n3.addSample(3);
values.addValue(new tr.v.NumericValue('foo', n1));
values.addValue(new tr.v.NumericValue('bar', n2));
values.addValue(new tr.v.NumericValue('baz', n3));
« no previous file with comments | « tracing/tracing/metrics/cpu_process_metric.html ('k') | tracing/tracing/metrics/sample_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698