Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: tracing/tracing/metrics/system_health/hazard_metric.html

Issue 2283213002: Rename Histogram.add() to addSample(). (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 Copyright (c) 2015 The Chromium Authors. All rights reserved. 3 Copyright (c) 2015 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <link rel="import" href="/tracing/metrics/metric_registry.html"> 8 <link rel="import" href="/tracing/metrics/metric_registry.html">
9 <link rel="import" href="/tracing/metrics/system_health/long_tasks_metric.html"> 9 <link rel="import" href="/tracing/metrics/system_health/long_tasks_metric.html">
10 <link rel="import" href="/tracing/value/numeric.html"> 10 <link rel="import" href="/tracing/value/numeric.html">
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 * been impacted by long tasks. 119 * been impacted by long tasks.
120 * This metric requires only the 'toplevel' tracing category. 120 * This metric requires only the 'toplevel' tracing category.
121 */ 121 */
122 function hazardMetric(values, model) { 122 function hazardMetric(values, model) {
123 var overallHazard = computeHazardForLongTasks(model); 123 var overallHazard = computeHazardForLongTasks(model);
124 if (overallHazard === undefined) 124 if (overallHazard === undefined)
125 overallHazard = 0; 125 overallHazard = 0;
126 126
127 var hist = new tr.v.Histogram( 127 var hist = new tr.v.Histogram(
128 tr.v.Unit.byName.normalizedPercentage_smallerIsBetter); 128 tr.v.Unit.byName.normalizedPercentage_smallerIsBetter);
129 hist.add(overallHazard); 129 hist.addSample(overallHazard);
130 values.addValue(new tr.v.NumericValue('hazard', hist)); 130 values.addValue(new tr.v.NumericValue('hazard', hist));
131 } 131 }
132 132
133 tr.metrics.MetricRegistry.register(hazardMetric); 133 tr.metrics.MetricRegistry.register(hazardMetric);
134 134
135 return { 135 return {
136 hazardMetric: hazardMetric, 136 hazardMetric: hazardMetric,
137 computeHazardForLongTasksInRangeOnThread: 137 computeHazardForLongTasksInRangeOnThread:
138 computeHazardForLongTasksInRangeOnThread, 138 computeHazardForLongTasksInRangeOnThread,
139 computeHazardForLongTasks: computeHazardForLongTasks, 139 computeHazardForLongTasks: computeHazardForLongTasks,
140 computeResponsivenessRisk: computeResponsivenessRisk 140 computeResponsivenessRisk: computeResponsivenessRisk
141 }; 141 };
142 }); 142 });
143 </script> 143 </script>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698