Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, robertshield, cbentzel+watch_chromium.org, vsevik, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, kkania, yoshiki+watch_chromium.org, yurys, davidbarr+watch_chromium.org, yuzo+watch_chromium.org, Aaron Boodman, chrome-speed-team+watch_google.com, native-client-reviews_googlegroups.com, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, tfarina, chromium-apps-reviews_chromium.org, ctguil+watch_chromium.org, pfeldman, zork+watch_chromium.org
Visibility:
Public.

Description

Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" Linux fixes, Part 1 of N BUG=110610 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203632

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+648 lines, -623 lines) Patch
M chrome/common/automation_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/cancelable_task_tracker_unittest.cc View 4 chunks +19 lines, -30 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_manifest_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 11 chunks +19 lines, -20 lines 0 comments Download
M chrome/common/extensions/extension_messages.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_set_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_sync_type_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 3 chunks +24 lines, -22 lines 0 comments Download
M chrome/common/extensions/manifest_handler_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/shared_module_manifest_unittest.cc View 3 chunks +23 lines, -14 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifest_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 4 chunks +19 lines, -17 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_kiosk_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc View 1 chunk +22 lines, -15 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_accessible_resources_unittest.cc View 1 chunk +18 lines, -18 lines 0 comments Download
M chrome/common/extensions/permissions/bluetooth_device_permission.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 16 chunks +45 lines, -46 lines 0 comments Download
M chrome/common/extensions/permissions/permissions_data.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/permissions/permissions_data_unittest.cc View 14 chunks +179 lines, -168 lines 0 comments Download
M chrome/common/extensions/unpacker.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/common/net/x509_certificate_model_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/nacl/nacl_ipc_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_ipc_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc View 3 chunks +8 lines, -28 lines 0 comments Download
M chrome/renderer/mock_printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/ppb_pdf_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/connector_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler_unittest.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M chrome/service/gaia/service_gaia_authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/net/service_url_request_context.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/service/service_ipc_server.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/service/service_process.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/automation/automation_handle_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/test/base/web_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/devtools_http_client.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/command_executor_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/commands.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/adb_client_socket.cc View 6 chunks +36 lines, -16 lines 0 comments Download
M chrome/test/chromedriver/net/net_util_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/test/chromedriver/net/test_http_server.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/net/websocket.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/perf/perf_ui_test_suite.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/reliability/automated_ui_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_automation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/profile_import_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
TBR
7 years, 6 months ago (2013-06-01 01:35:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/15836003/1
7 years, 6 months ago (2013-06-01 01:35:56 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/test/chromedriver/command_executor_impl.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-01 01:36:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/15836003/5001
7 years, 6 months ago (2013-06-01 02:28:27 UTC) #4
darin (slow to review)
LGTM
7 years, 6 months ago (2013-06-01 04:14:50 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-02 23:37:05 UTC) #6
Message was sent while issue was closed.
Change committed as 203632

Powered by Google App Engine
This is Rietveld 408576698