chrome/common/extensions/extension_messages.cc - Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_messages.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/extension_file_util_unittest.cc ('k') | chrome/common/extensions/extension_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_messages.cc

diff --git a/chrome/common/extensions/extension_messages.cc b/chrome/common/extensions/extension_messages.cc

index 44b475878c1421aca7da13dff846b3a9bb952cc6..e32b48dee7cb60a4fe55df571d6131a54540669c 100644

--- a/chrome/common/extensions/extension_messages.cc

+++ b/chrome/common/extensions/extension_messages.cc

@@ -42,9 +42,9 @@ scoped_refptr<Extension> ExtensionMsg_Loaded_Params::ConvertToExtension(

std::string* error) const {

scoped_refptr<Extension> extension =

Extension::Create(path, location, *manifest, creation_flags, error);

- if (extension) {

+ if (extension.get()) {

extensions::PermissionsData::SetActivePermissions(

- extension,

+ extension.get(),

new PermissionSet(apis, explicit_hosts, scriptable_hosts));

}

return extension;

« no previous file with comments | « chrome/common/extensions/extension_file_util_unittest.cc ('k') | chrome/common/extensions/extension_set_unittest.cc » ('j') | no next file with comments »