Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc
index 9da54dfb3ba4f9cca63a25ca58a616d299b14cbd..224062cfa8d34624660727057b85b6842a550e35 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc
@@ -17,19 +17,19 @@ TEST_F(OptionsPageManifestTest, OptionsPageInApps) {
// Allow options page with absolute URL in hosted apps.
extension = LoadAndExpectSuccess("hosted_app_absolute_options.json");
- EXPECT_STREQ(
- "http",
- extensions::ManifestURL::GetOptionsPage(extension).scheme().c_str());
+ EXPECT_STREQ("http",
+ extensions::ManifestURL::GetOptionsPage(extension.get())
+ .scheme().c_str());
EXPECT_STREQ(
"example.com",
- extensions::ManifestURL::GetOptionsPage(extension).host().c_str());
- EXPECT_STREQ(
- "options.html",
- extensions::ManifestURL::
- GetOptionsPage(extension).ExtractFileName().c_str());
+ extensions::ManifestURL::GetOptionsPage(extension.get()).host().c_str());
+ EXPECT_STREQ("options.html",
+ extensions::ManifestURL::GetOptionsPage(extension.get())
+ .ExtractFileName().c_str());
extension = LoadAndExpectSuccess("platform_app_with_options_page.json");
- EXPECT_TRUE(extensions::ManifestURL::GetOptionsPage(extension).is_empty());
+ EXPECT_TRUE(extensions::ManifestURL::GetOptionsPage(extension.get())
+ .is_empty());
Testcase testcases[] = {
// Forbid options page with relative URL in hosted apps.

Powered by Google App Engine
This is Rietveld 408576698