Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7307)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
index 62c102383a549d8ee98769a3642709b531ed58c0..ae4620b387b862dbae56cb91404f90ee2f9efd60 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
@@ -23,15 +23,15 @@ class PlatformAppsManifestTest : public ExtensionManifestTest {
TEST_F(PlatformAppsManifestTest, PlatformApps) {
scoped_refptr<Extension> extension =
LoadAndExpectSuccess("init_valid_platform_app.json");
- EXPECT_TRUE(AppIsolationInfo::HasIsolatedStorage(extension));
- EXPECT_TRUE(IncognitoInfo::IsSplitMode(extension));
+ EXPECT_TRUE(AppIsolationInfo::HasIsolatedStorage(extension.get()));
+ EXPECT_TRUE(IncognitoInfo::IsSplitMode(extension.get()));
extension =
LoadAndExpectSuccess("init_valid_platform_app_no_manifest_version.json");
EXPECT_EQ(2, extension->manifest_version());
extension = LoadAndExpectSuccess("incognito_valid_platform_app.json");
- EXPECT_TRUE(IncognitoInfo::IsSplitMode(extension));
+ EXPECT_TRUE(IncognitoInfo::IsSplitMode(extension.get()));
Testcase error_testcases[] = {
Testcase("init_invalid_platform_app_2.json",
@@ -87,9 +87,9 @@ TEST_F(PlatformAppsManifestTest, PlatformAppContentSecurityPolicy) {
EXPECT_EQ(0U, extension->install_warnings().size())
<< "Unexpected warning " << extension->install_warnings()[0].message;
EXPECT_TRUE(extension->is_platform_app());
- EXPECT_EQ(
- "default-src 'self' https://www.google.com",
- CSPInfo::GetResourceContentSecurityPolicy(extension, std::string()));
+ EXPECT_EQ("default-src 'self' https://www.google.com",
+ CSPInfo::GetResourceContentSecurityPolicy(extension.get(),
+ std::string()));
// But even whitelisted ones must specify a secure policy.
LoadAndExpectError(

Powered by Google App Engine
This is Rietveld 408576698