Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7356)

Unified Diff: chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc
diff --git a/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc b/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc
index 8ec017c189daac10f7d68c6d6b2804393bfad45f..5438a93e581cddb0b8d347f65d38f15a439bb6b5 100644
--- a/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc
+++ b/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc
@@ -47,21 +47,21 @@ class SyncWebSocketImplTest : public testing::Test {
} // namespace
TEST_F(SyncWebSocketImplTest, CreateDestroy) {
- SyncWebSocketImpl sock(context_getter_);
+ SyncWebSocketImpl sock(context_getter_.get());
}
TEST_F(SyncWebSocketImplTest, Connect) {
- SyncWebSocketImpl sock(context_getter_);
+ SyncWebSocketImpl sock(context_getter_.get());
ASSERT_TRUE(sock.Connect(server_.web_socket_url()));
}
TEST_F(SyncWebSocketImplTest, ConnectFail) {
- SyncWebSocketImpl sock(context_getter_);
+ SyncWebSocketImpl sock(context_getter_.get());
ASSERT_FALSE(sock.Connect(GURL("ws://127.0.0.1:33333")));
}
TEST_F(SyncWebSocketImplTest, SendReceive) {
- SyncWebSocketImpl sock(context_getter_);
+ SyncWebSocketImpl sock(context_getter_.get());
ASSERT_TRUE(sock.Connect(server_.web_socket_url()));
ASSERT_TRUE(sock.Send("hi"));
std::string message;
@@ -70,7 +70,7 @@ TEST_F(SyncWebSocketImplTest, SendReceive) {
}
TEST_F(SyncWebSocketImplTest, SendReceiveLarge) {
- SyncWebSocketImpl sock(context_getter_);
+ SyncWebSocketImpl sock(context_getter_.get());
ASSERT_TRUE(sock.Connect(server_.web_socket_url()));
std::string wrote_message(10 << 20, 'a');
ASSERT_TRUE(sock.Send(wrote_message));
@@ -81,7 +81,7 @@ TEST_F(SyncWebSocketImplTest, SendReceiveLarge) {
}
TEST_F(SyncWebSocketImplTest, SendReceiveMany) {
- SyncWebSocketImpl sock(context_getter_);
+ SyncWebSocketImpl sock(context_getter_.get());
ASSERT_TRUE(sock.Connect(server_.web_socket_url()));
ASSERT_TRUE(sock.Send("1"));
ASSERT_TRUE(sock.Send("2"));
@@ -97,7 +97,7 @@ TEST_F(SyncWebSocketImplTest, SendReceiveMany) {
TEST_F(SyncWebSocketImplTest, CloseOnReceive) {
server_.SetMessageAction(TestHttpServer::kCloseOnMessage);
- SyncWebSocketImpl sock(context_getter_);
+ SyncWebSocketImpl sock(context_getter_.get());
ASSERT_TRUE(sock.Connect(server_.web_socket_url()));
ASSERT_TRUE(sock.Send("1"));
std::string message;
@@ -106,14 +106,14 @@ TEST_F(SyncWebSocketImplTest, CloseOnReceive) {
}
TEST_F(SyncWebSocketImplTest, CloseOnSend) {
- SyncWebSocketImpl sock(context_getter_);
+ SyncWebSocketImpl sock(context_getter_.get());
ASSERT_TRUE(sock.Connect(server_.web_socket_url()));
server_.Stop();
ASSERT_FALSE(sock.Send("1"));
}
TEST_F(SyncWebSocketImplTest, Reconnect) {
- SyncWebSocketImpl sock(context_getter_);
+ SyncWebSocketImpl sock(context_getter_.get());
ASSERT_TRUE(sock.Connect(server_.web_socket_url()));
ASSERT_TRUE(sock.Send("1"));
// Wait for SyncWebSocket to receive the response from the server.
« no previous file with comments | « chrome/test/chromedriver/net/sync_websocket_factory.cc ('k') | chrome/test/chromedriver/net/test_http_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698