Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3414)

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/web_ui_browsertest.cc ('k') | chrome/test/chromedriver/command_executor_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/devtools_http_client.cc
diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.cc b/chrome/test/chromedriver/chrome/devtools_http_client.cc
index 0d74aff8c72424e22be650ec275ff04aa9c472fa..ce76661b3a9a836b902c1640b65a6bbc625e44d1 100644
--- a/chrome/test/chromedriver/chrome/devtools_http_client.cc
+++ b/chrome/test/chromedriver/chrome/devtools_http_client.cc
@@ -78,7 +78,8 @@ DevToolsHttpClient::~DevToolsHttpClient() {}
Status DevToolsHttpClient::GetVersion(std::string* version) {
std::string data;
- if (!FetchUrlAndLog(server_url_ + "/json/version", context_getter_, &data))
+ if (!FetchUrlAndLog(
+ server_url_ + "/json/version", context_getter_.get(), &data))
return Status(kChromeNotReachable);
return internal::ParseVersionInfo(data, version);
@@ -86,7 +87,7 @@ Status DevToolsHttpClient::GetVersion(std::string* version) {
Status DevToolsHttpClient::GetWebViewsInfo(WebViewsInfo* views_info) {
std::string data;
- if (!FetchUrlAndLog(server_url_ + "/json", context_getter_, &data))
+ if (!FetchUrlAndLog(server_url_ + "/json", context_getter_.get(), &data))
return Status(kChromeNotReachable);
return internal::ParseWebViewsInfo(data, views_info);
@@ -106,7 +107,7 @@ scoped_ptr<DevToolsClient> DevToolsHttpClient::CreateClient(
Status DevToolsHttpClient::CloseWebView(const std::string& id) {
std::string data;
if (!FetchUrlAndLog(
- server_url_ + "/json/close/" + id, context_getter_, &data)) {
+ server_url_ + "/json/close/" + id, context_getter_.get(), &data)) {
return Status(kOk); // Closing the last web view leads chrome to quit.
}
« no previous file with comments | « chrome/test/base/web_ui_browsertest.cc ('k') | chrome/test/chromedriver/command_executor_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698