chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc - Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_kiosk_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

index 4fc698cf0d3cd70c1be9f787ad02f16eaf1d727a..64190a8444d1182f0237e70eccde6121a6cb6867 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc

@@ -20,22 +20,22 @@ TEST_F(ExtensionManifestOfflineEnabledTest, OfflineEnabled) {

errors::kInvalidOfflineEnabled);

scoped_refptr<Extension> extension_0(

LoadAndExpectSuccess("offline_enabled_extension.json"));

- EXPECT_TRUE(OfflineEnabledInfo::IsOfflineEnabled(extension_0));

+ EXPECT_TRUE(OfflineEnabledInfo::IsOfflineEnabled(extension_0.get()));

scoped_refptr<Extension> extension_1(

LoadAndExpectSuccess("offline_enabled_packaged_app.json"));

- EXPECT_TRUE(OfflineEnabledInfo::IsOfflineEnabled(extension_1));

+ EXPECT_TRUE(OfflineEnabledInfo::IsOfflineEnabled(extension_1.get()));

scoped_refptr<Extension> extension_2(

LoadAndExpectSuccess("offline_disabled_packaged_app.json"));

- EXPECT_FALSE(OfflineEnabledInfo::IsOfflineEnabled(extension_2));

+ EXPECT_FALSE(OfflineEnabledInfo::IsOfflineEnabled(extension_2.get()));

scoped_refptr<Extension> extension_3(

LoadAndExpectSuccess("offline_default_packaged_app.json"));

- EXPECT_FALSE(OfflineEnabledInfo::IsOfflineEnabled(extension_3));

+ EXPECT_FALSE(OfflineEnabledInfo::IsOfflineEnabled(extension_3.get()));

scoped_refptr<Extension> extension_4(

LoadAndExpectSuccess("offline_enabled_hosted_app.json"));

- EXPECT_TRUE(OfflineEnabledInfo::IsOfflineEnabled(extension_4));

+ EXPECT_TRUE(OfflineEnabledInfo::IsOfflineEnabled(extension_4.get()));

scoped_refptr<Extension> extension_5(

LoadAndExpectSuccess("offline_default_platform_app.json"));

- EXPECT_TRUE(OfflineEnabledInfo::IsOfflineEnabled(extension_5));

+ EXPECT_TRUE(OfflineEnabledInfo::IsOfflineEnabled(extension_5.get()));

}

} // namespace extensions