Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: chrome/common/extensions/permissions/permission_set.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/permissions/permission_set.h" 5 #include "chrome/common/extensions/permissions/permission_set.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <string> 9 #include <string>
10 10
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 AddPatternsAndRemovePaths(explicit_hosts, &explicit_hosts_); 113 AddPatternsAndRemovePaths(explicit_hosts, &explicit_hosts_);
114 InitImplicitPermissions(); 114 InitImplicitPermissions();
115 InitEffectiveHosts(); 115 InitEffectiveHosts();
116 } 116 }
117 117
118 // static 118 // static
119 PermissionSet* PermissionSet::CreateDifference( 119 PermissionSet* PermissionSet::CreateDifference(
120 const PermissionSet* set1, 120 const PermissionSet* set1,
121 const PermissionSet* set2) { 121 const PermissionSet* set2) {
122 scoped_refptr<PermissionSet> empty = new PermissionSet(); 122 scoped_refptr<PermissionSet> empty = new PermissionSet();
123 const PermissionSet* set1_safe = (set1 == NULL) ? empty : set1; 123 const PermissionSet* set1_safe = (set1 == NULL) ? empty.get() : set1;
124 const PermissionSet* set2_safe = (set2 == NULL) ? empty : set2; 124 const PermissionSet* set2_safe = (set2 == NULL) ? empty.get() : set2;
125 125
126 APIPermissionSet apis; 126 APIPermissionSet apis;
127 APIPermissionSet::Difference(set1_safe->apis(), set2_safe->apis(), &apis); 127 APIPermissionSet::Difference(set1_safe->apis(), set2_safe->apis(), &apis);
128 128
129 URLPatternSet explicit_hosts; 129 URLPatternSet explicit_hosts;
130 URLPatternSet::CreateDifference(set1_safe->explicit_hosts(), 130 URLPatternSet::CreateDifference(set1_safe->explicit_hosts(),
131 set2_safe->explicit_hosts(), 131 set2_safe->explicit_hosts(),
132 &explicit_hosts); 132 &explicit_hosts);
133 133
134 URLPatternSet scriptable_hosts; 134 URLPatternSet scriptable_hosts;
135 URLPatternSet::CreateDifference(set1_safe->scriptable_hosts(), 135 URLPatternSet::CreateDifference(set1_safe->scriptable_hosts(),
136 set2_safe->scriptable_hosts(), 136 set2_safe->scriptable_hosts(),
137 &scriptable_hosts); 137 &scriptable_hosts);
138 138
139 return new PermissionSet(apis, explicit_hosts, scriptable_hosts); 139 return new PermissionSet(apis, explicit_hosts, scriptable_hosts);
140 } 140 }
141 141
142 // static 142 // static
143 PermissionSet* PermissionSet::CreateIntersection( 143 PermissionSet* PermissionSet::CreateIntersection(
144 const PermissionSet* set1, 144 const PermissionSet* set1,
145 const PermissionSet* set2) { 145 const PermissionSet* set2) {
146 scoped_refptr<PermissionSet> empty = new PermissionSet(); 146 scoped_refptr<PermissionSet> empty = new PermissionSet();
147 const PermissionSet* set1_safe = (set1 == NULL) ? empty : set1; 147 const PermissionSet* set1_safe = (set1 == NULL) ? empty.get() : set1;
148 const PermissionSet* set2_safe = (set2 == NULL) ? empty : set2; 148 const PermissionSet* set2_safe = (set2 == NULL) ? empty.get() : set2;
149 149
150 APIPermissionSet apis; 150 APIPermissionSet apis;
151 APIPermissionSet::Intersection(set1_safe->apis(), set2_safe->apis(), &apis); 151 APIPermissionSet::Intersection(set1_safe->apis(), set2_safe->apis(), &apis);
152 152
153 URLPatternSet explicit_hosts; 153 URLPatternSet explicit_hosts;
154 URLPatternSet::CreateIntersection(set1_safe->explicit_hosts(), 154 URLPatternSet::CreateIntersection(set1_safe->explicit_hosts(),
155 set2_safe->explicit_hosts(), 155 set2_safe->explicit_hosts(),
156 &explicit_hosts); 156 &explicit_hosts);
157 157
158 URLPatternSet scriptable_hosts; 158 URLPatternSet scriptable_hosts;
159 URLPatternSet::CreateIntersection(set1_safe->scriptable_hosts(), 159 URLPatternSet::CreateIntersection(set1_safe->scriptable_hosts(),
160 set2_safe->scriptable_hosts(), 160 set2_safe->scriptable_hosts(),
161 &scriptable_hosts); 161 &scriptable_hosts);
162 162
163 return new PermissionSet(apis, explicit_hosts, scriptable_hosts); 163 return new PermissionSet(apis, explicit_hosts, scriptable_hosts);
164 } 164 }
165 165
166 // static 166 // static
167 PermissionSet* PermissionSet::CreateUnion( 167 PermissionSet* PermissionSet::CreateUnion(
168 const PermissionSet* set1, 168 const PermissionSet* set1,
169 const PermissionSet* set2) { 169 const PermissionSet* set2) {
170 scoped_refptr<PermissionSet> empty = new PermissionSet(); 170 scoped_refptr<PermissionSet> empty = new PermissionSet();
171 const PermissionSet* set1_safe = (set1 == NULL) ? empty : set1; 171 const PermissionSet* set1_safe = (set1 == NULL) ? empty.get() : set1;
172 const PermissionSet* set2_safe = (set2 == NULL) ? empty : set2; 172 const PermissionSet* set2_safe = (set2 == NULL) ? empty.get() : set2;
173 173
174 APIPermissionSet apis; 174 APIPermissionSet apis;
175 APIPermissionSet::Union(set1_safe->apis(), set2_safe->apis(), &apis); 175 APIPermissionSet::Union(set1_safe->apis(), set2_safe->apis(), &apis);
176 176
177 URLPatternSet explicit_hosts; 177 URLPatternSet explicit_hosts;
178 URLPatternSet::CreateUnion(set1_safe->explicit_hosts(), 178 URLPatternSet::CreateUnion(set1_safe->explicit_hosts(),
179 set2_safe->explicit_hosts(), 179 set2_safe->explicit_hosts(),
180 &explicit_hosts); 180 &explicit_hosts);
181 181
182 URLPatternSet scriptable_hosts; 182 URLPatternSet scriptable_hosts;
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
600 std::set<std::string> new_hosts_only; 600 std::set<std::string> new_hosts_only;
601 601
602 std::set_difference(new_hosts_set.begin(), new_hosts_set.end(), 602 std::set_difference(new_hosts_set.begin(), new_hosts_set.end(),
603 old_hosts_set.begin(), old_hosts_set.end(), 603 old_hosts_set.begin(), old_hosts_set.end(),
604 std::inserter(new_hosts_only, new_hosts_only.begin())); 604 std::inserter(new_hosts_only, new_hosts_only.begin()));
605 605
606 return !new_hosts_only.empty(); 606 return !new_hosts_only.empty();
607 } 607 }
608 608
609 } // namespace extensions 609 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698