Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3947)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc
index 0b2c184792aaa314bfe6e81e9d886e9a0aaf0723..6e1779e1f3649c3ee2cbba32ca16821c9888fe79 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc
@@ -34,15 +34,16 @@ TEST_F(HomepageURLManifestTest, GetHomepageURL) {
scoped_refptr<extensions::Extension> extension(
LoadAndExpectSuccess("homepage_valid.json"));
EXPECT_EQ(GURL("http://foo.com#bar"),
- extensions::ManifestURL::GetHomepageURL(extension));
+ extensions::ManifestURL::GetHomepageURL(extension.get()));
// The Google Gallery URL ends with the id, which depends on the path, which
// can be different in testing, so we just check the part before id.
extension = LoadAndExpectSuccess("homepage_google_hosted.json");
EXPECT_TRUE(StartsWithASCII(
- extensions::ManifestURL::GetHomepageURL(extension).spec(),
- "https://chrome.google.com/webstore/detail/", false));
+ extensions::ManifestURL::GetHomepageURL(extension.get()).spec(),
+ "https://chrome.google.com/webstore/detail/",
+ false));
extension = LoadAndExpectSuccess("homepage_externally_hosted.json");
- EXPECT_EQ(GURL(), extensions::ManifestURL::GetHomepageURL(extension));
+ EXPECT_EQ(GURL(), extensions::ManifestURL::GetHomepageURL(extension.get()));
}

Powered by Google App Engine
This is Rietveld 408576698