Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_manifest_constants.h" 5 #include "chrome/common/extensions/extension_manifest_constants.h"
6 #include "chrome/common/extensions/manifest_handlers/requirements_handler.h" 6 #include "chrome/common/extensions/manifest_handlers/requirements_handler.h"
7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
8 #include "extensions/common/error_utils.h" 8 #include "extensions/common/error_utils.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 }; 44 };
45 45
46 RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR); 46 RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR);
47 } 47 }
48 48
49 TEST_F(RequirementsManifestTest, RequirementsValid) { 49 TEST_F(RequirementsManifestTest, RequirementsValid) {
50 // Test the defaults. 50 // Test the defaults.
51 scoped_refptr<Extension> extension(LoadAndExpectSuccess( 51 scoped_refptr<Extension> extension(LoadAndExpectSuccess(
52 "requirements_valid_empty.json")); 52 "requirements_valid_empty.json"));
53 ASSERT_TRUE(extension.get()); 53 ASSERT_TRUE(extension.get());
54 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).webgl, false); 54 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).webgl, false);
55 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).css3d, false); 55 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).css3d, false);
56 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).npapi, false); 56 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).npapi, false);
57 57
58 // Test loading all the requirements. 58 // Test loading all the requirements.
59 extension = LoadAndExpectSuccess("requirements_valid_full.json"); 59 extension = LoadAndExpectSuccess("requirements_valid_full.json");
60 ASSERT_TRUE(extension.get()); 60 ASSERT_TRUE(extension.get());
61 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).webgl, true); 61 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).webgl, true);
62 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).css3d, true); 62 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).css3d, true);
63 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).npapi, true); 63 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).npapi, true);
64 } 64 }
65 65
66 // When an npapi plugin is present, the default of the "npapi" requirement 66 // When an npapi plugin is present, the default of the "npapi" requirement
67 // changes. 67 // changes.
68 TEST_F(RequirementsManifestTest, RequirementsNpapiDefault) { 68 TEST_F(RequirementsManifestTest, RequirementsNpapiDefault) {
69 scoped_refptr<Extension> extension(LoadAndExpectSuccess( 69 scoped_refptr<Extension> extension(LoadAndExpectSuccess(
70 "requirements_npapi_empty.json")); 70 "requirements_npapi_empty.json"));
71 ASSERT_TRUE(extension.get()); 71 ASSERT_TRUE(extension.get());
72 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).webgl, false); 72 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).webgl, false);
73 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).css3d, false); 73 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).css3d, false);
74 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).npapi, true); 74 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).npapi, true);
75 75
76 extension = LoadAndExpectSuccess( 76 extension = LoadAndExpectSuccess(
77 "requirements_npapi_empty_plugins_empty.json"); 77 "requirements_npapi_empty_plugins_empty.json");
78 ASSERT_TRUE(extension.get()); 78 ASSERT_TRUE(extension.get());
79 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).webgl, false); 79 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).webgl, false);
80 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).css3d, false); 80 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).css3d, false);
81 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).npapi, false); 81 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).npapi, false);
82 82
83 extension = LoadAndExpectSuccess("requirements_npapi.json"); 83 extension = LoadAndExpectSuccess("requirements_npapi.json");
84 ASSERT_TRUE(extension.get()); 84 ASSERT_TRUE(extension.get());
85 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).webgl, false); 85 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).webgl, false);
86 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).css3d, false); 86 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).css3d, false);
87 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).npapi, false); 87 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).npapi, false);
88 88
89 extension = LoadAndExpectSuccess("requirements_npapi_plugins_empty.json"); 89 extension = LoadAndExpectSuccess("requirements_npapi_plugins_empty.json");
90 ASSERT_TRUE(extension.get()); 90 ASSERT_TRUE(extension.get());
91 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).webgl, false); 91 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).webgl, false);
92 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).css3d, false); 92 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).css3d, false);
93 EXPECT_EQ(RequirementsInfo::GetRequirements(extension).npapi, true); 93 EXPECT_EQ(RequirementsInfo::GetRequirements(extension.get()).npapi, true);
94 } 94 }
95 95
96 } // namespace extensions 96 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698