Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_manifest_constants.h" 5 #include "chrome/common/extensions/extension_manifest_constants.h"
6 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 6 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
7 #include "chrome/common/extensions/manifest_url_handler.h" 7 #include "chrome/common/extensions/manifest_url_handler.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace errors = extension_manifest_errors; 10 namespace errors = extension_manifest_errors;
11 11
12 class URLOverridesManifestTest : public ExtensionManifestTest { 12 class URLOverridesManifestTest : public ExtensionManifestTest {
13 }; 13 };
14 14
15 TEST_F(URLOverridesManifestTest, Override) { 15 TEST_F(URLOverridesManifestTest, Override) {
16 Testcase testcases[] = { 16 Testcase testcases[] = {
17 Testcase("override_newtab_and_history.json", errors::kMultipleOverrides), 17 Testcase("override_newtab_and_history.json", errors::kMultipleOverrides),
18 Testcase("override_invalid_page.json", errors::kInvalidChromeURLOverrides) 18 Testcase("override_invalid_page.json", errors::kInvalidChromeURLOverrides)
19 }; 19 };
20 RunTestcases(testcases, arraysize(testcases), 20 RunTestcases(testcases, arraysize(testcases),
21 EXPECT_TYPE_ERROR); 21 EXPECT_TYPE_ERROR);
22 22
23 scoped_refptr<extensions::Extension> extension; 23 scoped_refptr<extensions::Extension> extension;
24 24
25 extension = LoadAndExpectSuccess("override_new_tab.json"); 25 extension = LoadAndExpectSuccess("override_new_tab.json");
26 EXPECT_EQ(extension->url().spec() + "newtab.html", 26 EXPECT_EQ(extension->url().spec() + "newtab.html",
27 extensions::URLOverrides::GetChromeURLOverrides(extension). 27 extensions::URLOverrides::GetChromeURLOverrides(extension.get())
28 find("newtab")->second.spec()); 28 .find("newtab")->second.spec());
29 29
30 extension = LoadAndExpectSuccess("override_history.json"); 30 extension = LoadAndExpectSuccess("override_history.json");
31 EXPECT_EQ(extension->url().spec() + "history.html", 31 EXPECT_EQ(extension->url().spec() + "history.html",
32 extensions::URLOverrides::GetChromeURLOverrides(extension). 32 extensions::URLOverrides::GetChromeURLOverrides(extension.get())
33 find("history")->second.spec()); 33 .find("history")->second.spec());
34 } 34 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698