Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/i18n/rtl.h" 5 #include "base/i18n/rtl.h"
6 #include "base/path_service.h" 6 #include "base/path_service.h"
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/common/chrome_paths.h" 8 #include "chrome/common/chrome_paths.h"
9 #include "chrome/common/extensions/extension.h" 9 #include "chrome/common/extensions/extension.h"
10 #include "chrome/common/extensions/extension_manifest_constants.h" 10 #include "chrome/common/extensions/extension_manifest_constants.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 EXPECT_EQ(path, extension->path()); 93 EXPECT_EQ(path, extension->path());
94 94
95 // Test permissions scheme. 95 // Test permissions scheme.
96 // We allow unknown API permissions, so this will be valid until we better 96 // We allow unknown API permissions, so this will be valid until we better
97 // distinguish between API and host permissions. 97 // distinguish between API and host permissions.
98 LoadAndExpectSuccess("init_valid_permissions.json"); 98 LoadAndExpectSuccess("init_valid_permissions.json");
99 99
100 // Test with an options page. 100 // Test with an options page.
101 extension = LoadAndExpectSuccess("init_valid_options.json"); 101 extension = LoadAndExpectSuccess("init_valid_options.json");
102 EXPECT_EQ("chrome-extension", 102 EXPECT_EQ("chrome-extension",
103 ManifestURL::GetOptionsPage(extension).scheme()); 103 ManifestURL::GetOptionsPage(extension.get()).scheme());
104 EXPECT_EQ("/options.html", 104 EXPECT_EQ("/options.html",
105 ManifestURL::GetOptionsPage(extension).path()); 105 ManifestURL::GetOptionsPage(extension.get()).path());
106 106
107 Testcase testcases[] = { 107 Testcase testcases[] = {
108 // Test that an empty list of page actions does not stop a browser action 108 // Test that an empty list of page actions does not stop a browser action
109 // from being loaded. 109 // from being loaded.
110 Testcase("init_valid_empty_page_actions.json"), 110 Testcase("init_valid_empty_page_actions.json"),
111 111
112 // Test with a minimum_chrome_version. 112 // Test with a minimum_chrome_version.
113 Testcase("init_valid_minimum_chrome.json"), 113 Testcase("init_valid_minimum_chrome.json"),
114 114
115 // Test a hosted app with a minimum_chrome_version. 115 // Test a hosted app with a minimum_chrome_version.
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 156
157 // Reset locale. 157 // Reset locale.
158 #if defined(TOOLKIT_GTK) 158 #if defined(TOOLKIT_GTK)
159 gtk_widget_set_default_direction(gtk_dir); 159 gtk_widget_set_default_direction(gtk_dir);
160 #else 160 #else
161 base::i18n::SetICUDefaultLocale(locale); 161 base::i18n::SetICUDefaultLocale(locale);
162 #endif 162 #endif
163 } 163 }
164 164
165 } // namespace extensions 165 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698