chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc - Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handler_unittest.cc ('k') | chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc

diff --git a/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc b/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc

index f2c3a918fc2929788b1eee73a71d2c4d18b65a5b..5b611f732375293a9e91f6929899c8655582158c 100644

--- a/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc

+++ b/chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc

@@ -49,8 +49,8 @@ TEST_F(ContentScriptsManifestTest, OnChromeUrlsWithFlag) {

scoped_refptr<Extension> extension =

LoadAndExpectSuccess("content_script_chrome_url_invalid.json");

const GURL newtab_url("chrome://newtab/");

- EXPECT_TRUE(ContentScriptsInfo::ExtensionHasScriptAtURL(extension,

- newtab_url));

+ EXPECT_TRUE(

+ ContentScriptsInfo::ExtensionHasScriptAtURL(extension.get(), newtab_url));

}

TEST_F(ContentScriptsManifestTest, ScriptableHosts) {

@@ -58,7 +58,7 @@ TEST_F(ContentScriptsManifestTest, ScriptableHosts) {

scoped_refptr<Extension> extension =

LoadAndExpectSuccess("content_script_yahoo.json");

URLPatternSet scriptable_hosts =

- ContentScriptsInfo::GetScriptableHosts(extension);

+ ContentScriptsInfo::GetScriptableHosts(extension.get());

URLPatternSet expected;

expected.AddPattern(