Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

Issue 15836003: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension.h" 5 #include "chrome/common/extensions/extension.h"
6 #include "chrome/common/extensions/extension_manifest_constants.h" 6 #include "chrome/common/extensions/extension_manifest_constants.h"
7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
8 #include "chrome/common/extensions/manifest_url_handler.h" 8 #include "chrome/common/extensions/manifest_url_handler.h"
9 #include "chrome/common/extensions/permissions/permissions_data.h" 9 #include "chrome/common/extensions/permissions/permissions_data.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 class DevToolsPageManifestTest : public ExtensionManifestTest { 12 class DevToolsPageManifestTest : public ExtensionManifestTest {
13 }; 13 };
14 14
15 TEST_F(DevToolsPageManifestTest, DevToolsExtensions) { 15 TEST_F(DevToolsPageManifestTest, DevToolsExtensions) {
16 LoadAndExpectError("devtools_extension_url_invalid_type.json", 16 LoadAndExpectError("devtools_extension_url_invalid_type.json",
17 extension_manifest_errors::kInvalidDevToolsPage); 17 extension_manifest_errors::kInvalidDevToolsPage);
18 18
19 scoped_refptr<extensions::Extension> extension; 19 scoped_refptr<extensions::Extension> extension;
20 extension = LoadAndExpectSuccess("devtools_extension.json"); 20 extension = LoadAndExpectSuccess("devtools_extension.json");
21 EXPECT_EQ(extension->url().spec() + "devtools.html", 21 EXPECT_EQ(extension->url().spec() + "devtools.html",
22 extensions::ManifestURL::GetDevToolsPage(extension).spec()); 22 extensions::ManifestURL::GetDevToolsPage(extension.get()).spec());
23 EXPECT_TRUE( 23 EXPECT_TRUE(extensions::PermissionsData::HasEffectiveAccessToAllHosts(
24 extensions::PermissionsData::HasEffectiveAccessToAllHosts(extension)); 24 extension.get()));
25 } 25 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698