Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10692195: Consolidate Browser Creation. (Closed)

Created:
8 years, 5 months ago by Ben Goodger (Google)
Modified:
8 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, feature-media-reviews_chromium.org, mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, ben+watch_chromium.org, ajwong+watch_chromium.org, kkania, Dmitry Titov, dcheng, marja+watch_chromium.org, rginda+watch_chromium.org, jennb, robertshield, jianli, oshima+watch_chromium.org, brettw-cc_chromium.org, Avi (use Gerrit), sadrul, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Consolidate Browser Creation. . Make all instantiators use a single ctor that takes CreateParams. . Get rid of InitBrowserWindow() and make CreateBrowserWindow() a anonymous namespace function in browser.cc http://crbug.com/133576 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148396

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+404 lines, -403 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/enrollment_dialog_view.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/media/media_player.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs.cc View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode_unittest.cc View 1 2 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/notifications/notification_options_menu_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/avatar_menu_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 2 5 chunks +17 lines, -8 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_global_error_unittest.cc View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 2 4 chunks +6 lines, -28 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 7 chunks +79 lines, -94 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 9 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/ui/browser_close_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_finder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_list_impl.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_list_observer.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_mac.cc View 1 2 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_model_delegate.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 2 6 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/cocoa_profile_test.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/cocoa_profile_test.mm View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window_unittest.mm View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_window.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc View 1 2 4 chunks +15 lines, -27 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_service_unittest.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/ash/app_list/extension_app_item.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/window_positioner_unittest.cc View 1 2 3 chunks +15 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_contents_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 2 4 chunks +21 lines, -32 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 2 3 chunks +10 lines, -1 line 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 2 2 chunks +46 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
The meaningful part of this change is in browser.cc, the rest is just updating all ...
8 years, 5 months ago (2012-07-24 20:14:07 UTC) #1
jam
8 years, 5 months ago (2012-07-24 20:43:19 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698