Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2749)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/base/browser_with_test_window_test.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc ('k') | chrome/test/base/in_process_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/browser_with_test_window_test.cc
===================================================================
--- chrome/test/base/browser_with_test_window_test.cc (revision 148382)
+++ chrome/test/base/browser_with_test_window_test.cc (working copy)
@@ -41,9 +41,10 @@
testing::Test::SetUp();
set_profile(CreateProfile());
- browser_.reset(new Browser(Browser::TYPE_TABBED, profile()));
- window_.reset(new TestBrowserWindow(browser()));
- browser_->SetWindowForTesting(window_.get());
+ window_.reset(new TestBrowserWindow);
+ Browser::CreateParams params(profile());
+ params.window = window_.get();
+ browser_.reset(new Browser(params));
#if defined(USE_AURA)
aura_test_helper_.reset(new aura::test::AuraTestHelper(&ui_loop_));
aura_test_helper_->SetUp();
« no previous file with comments | « chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc ('k') | chrome/test/base/in_process_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698