Consolidate Browser Creation.

chrome/browser/extensions/api/tabs/tabs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 224 matching lines @@
     use_existing_browser_window = true;
 #endif  // OS_WIN
 
   Browser* new_window = NULL;
   if (use_existing_browser_window)
     // The false parameter passed below is to ensure that we find a browser
     // object matching the profile passed in, instead of the original profile
     new_window = browser::FindTabbedBrowser(profile, false);
 
   if (!new_window)
-    new_window = Browser::CreateWithParams(params);
+    new_window = new Browser(params);
   return new_window;
 }
 
 }  // namespace
 
 // Windows ---------------------------------------------------------------------
 
 bool GetWindowFunction::RunImpl() {
   scoped_ptr<Get::Params> params(Get::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
@@ skipping 332 matching lines @@
 
     SetResult(
         panel->extension_window_controller()->CreateWindowValueWithTabs());
     return true;
   }
 #endif
     // else fall through to create BrowserWindow
   }
 
   // Create a new BrowserWindow.
-  Browser::CreateParams create_params;
+  Browser::CreateParams create_params(window_type, window_profile);
   if (extension_id.empty()) {
-    create_params = Browser::CreateParams(window_type, window_profile);
     create_params.initial_bounds = window_bounds;
   } else {
     create_params = Browser::CreateParams::CreateForApp(
         window_type,
         web_app::GenerateApplicationNameFromExtensionId(extension_id),
         (window_type == Browser::TYPE_PANEL ? panel_bounds : popup_bounds),
         window_profile);
   }
   create_params.initial_show_state = ui::SHOW_STATE_NORMAL;
 
@@ skipping 425 matching lines @@
     EXTENSION_FUNCTION_VALIDATE(args->GetBoolean(keys::kPinnedKey, &pinned));
 
   // We can't load extension URLs into incognito windows unless the extension
   // uses split mode. Special case to fall back to a tabbed window.
   if (url.SchemeIs(chrome::kExtensionScheme) &&
       !GetExtension()->incognito_split_mode() &&
       browser->profile()->IsOffTheRecord()) {
     Profile* profile = browser->profile()->GetOriginalProfile();
     browser = browser::FindTabbedBrowser(profile, false);
     if (!browser) {
-      browser = Browser::Create(profile);
+      browser = new Browser(Browser::CreateParams(profile));
       browser->window()->Show();
     }
   }
 
   // If index is specified, honor the value, but keep it bound to
   // -1 <= index <= tab_strip->count() where -1 invokes the default behavior.
   int index = -1;
   if (args->HasKey(keys::kIndexKey))
     EXTENSION_FUNCTION_VALIDATE(args->GetInteger(keys::kIndexKey, &index));
 
@@ skipping 755 matching lines @@
   // called for every API call the extension made.
   GotLanguage(language);
 }
 
 void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
   SetResult(Value::CreateStringValue(language.c_str()));
   SendResponse(true);
 
   Release();  // Balanced in Run()
 }