Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2115)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/chrome_web_contents_handler.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chrome_web_contents_handler.cc
===================================================================
--- chrome/browser/ui/webui/chrome_web_contents_handler.cc (revision 148382)
+++ chrome/browser/ui/webui/chrome_web_contents_handler.cc (working copy)
@@ -39,7 +39,7 @@
Browser* browser = browser::FindTabbedBrowser(profile, false);
const bool browser_created = !browser;
if (!browser)
- browser = Browser::Create(profile);
+ browser = new Browser(Browser::CreateParams(profile));
chrome::NavigateParams nav_params(browser, params.url, params.transition);
nav_params.referrer = params.referrer;
if (source && source->IsCrashed() &&
@@ -81,7 +81,7 @@
Browser* browser = browser::FindTabbedBrowser(profile, false);
const bool browser_created = !browser;
if (!browser)
- browser = Browser::Create(profile);
+ browser = new Browser(Browser::CreateParams(profile));
TabContents* tab_contents = new TabContents(new_contents);
chrome::NavigateParams params(browser, tab_contents);
// TODO(pinkerton): no way to get a TabContents for this.
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698