chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm - Issue 10692195: Consolidate Browser Creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

===================================================================

--- chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm (revision 148382)

+++ chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm (working copy)

@@ -95,7 +95,7 @@

- (void)openURLForNode:(const BookmarkNode*)node {

Browser* browser = browser::FindTabbedBrowser(bridge_->GetProfile(), true);

if (!browser)

- browser = Browser::Create(bridge_->GetProfile());

+ browser = new Browser(Browser::CreateParams(bridge_->GetProfile()));

WindowOpenDisposition disposition =

event_utils::WindowOpenDispositionFromNSEvent([NSApp currentEvent]);

OpenURLParams params(

@@ -114,7 +114,7 @@

Browser* browser = browser::FindTabbedBrowser(bridge_->GetProfile(), true);

if (!browser)

- browser = Browser::Create(bridge_->GetProfile());

+ browser = new Browser(Browser::CreateParams(bridge_->GetProfile()));

DCHECK(browser);

if (!node || !browser)