Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3626)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/ash/app_list/extension_app_item.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc ('k') | chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/ash/app_list/extension_app_item.cc
===================================================================
--- chrome/browser/ui/views/ash/app_list/extension_app_item.cc (revision 148382)
+++ chrome/browser/ui/views/ash/app_list/extension_app_item.cc (working copy)
@@ -167,9 +167,10 @@
if (!extension)
return;
+ // TODO(beng): use Navigate()!
Browser* browser = browser::FindLastActiveWithProfile(profile_);
if (!browser) {
- browser = Browser::Create(profile_);
+ browser = new Browser(Browser::CreateParams(profile_));
browser->window()->Show();
}
« no previous file with comments | « chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc ('k') | chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698