Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3155)

Unified Diff: chrome/browser/ui/cocoa/cocoa_profile_test.h

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/cocoa_profile_test.h
===================================================================
--- chrome/browser/ui/cocoa/cocoa_profile_test.h (revision 148382)
+++ chrome/browser/ui/cocoa/cocoa_profile_test.h (working copy)
@@ -47,15 +47,15 @@
TestingProfile* profile() { return profile_; }
Browser* browser() { return browser_.get(); }
- // Creates the browser window. To close this window call |CloseBrowserWindow|.
- // Do NOT call close directly on the window.
- BrowserWindow* CreateBrowserWindow();
-
- // Closes the window for this browser. This must only be called after
- // CreateBrowserWindow(). This will automatically be called as part of
- // TearDown() if it's not been done already.
+ // Closes the window for this browser. This will automatically be called as
+ // part of TearDown() if it's not been done already.
void CloseBrowserWindow();
+ protected:
+ // Overridden by test subclasses to create their own browser, e.g. with a
+ // test window.
+ virtual Browser* CreateBrowser();
+
private:
MessageLoopForUI message_loop_;
content::TestBrowserThread ui_thread_;
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/cocoa_profile_test.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698