chrome/browser/app_controller_mac.mm - Issue 10692195: Consolidate Browser Creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/app_controller_mac.mm

===================================================================

--- chrome/browser/app_controller_mac.mm (revision 148382)

+++ chrome/browser/app_controller_mac.mm (working copy)

@@ -675,7 +675,7 @@

// downloads page if the user chooses to wait.

Browser* browser = browser::FindBrowserWithProfile(profiles[i]);

if (!browser) {

- browser = Browser::Create(profiles[i]);

+ browser = new Browser(Browser::CreateParams(profiles[i]));

browser->window()->Show();

}

DCHECK(browser);

@@ -1093,7 +1093,7 @@

Browser* browser = browser::GetLastActiveBrowser();

// if no browser window exists then create one with no tabs to be filled in

if (!browser) {

- browser = Browser::Create([self lastProfile]);

+ browser = new Browser(Browser::CreateParams([self lastProfile]));

browser->window()->Show();

}

« no previous file with comments | « no previous file | chrome/browser/automation/testing_automation_provider.cc » ('j') | no next file with comments »