Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3981)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_close_browsertest.cc ('k') | chrome/browser/ui/browser_finder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_commands.cc
===================================================================
--- chrome/browser/ui/browser_commands.cc (revision 148382)
+++ chrome/browser/ui/browser_commands.cc (working copy)
@@ -101,7 +101,7 @@
}
case NEW_WINDOW: {
current_tab = current_tab->Clone();
- Browser* b = Browser::Create(browser->profile());
+ Browser* b = new Browser(Browser::CreateParams(browser->profile()));
b->tab_strip_model()->AddTabContents(
current_tab, -1, content::PAGE_TRANSITION_LINK,
TabStripModel::ADD_ACTIVE);
@@ -254,7 +254,7 @@
}
Browser* OpenEmptyWindow(Profile* profile) {
- Browser* browser = Browser::Create(profile);
+ Browser* browser = new Browser(Browser::CreateParams(profile));
AddBlankTab(browser, true);
browser->window()->Show();
return browser;
@@ -507,13 +507,13 @@
if (browser->is_app()) {
CHECK(!browser->is_type_popup());
CHECK(!browser->is_type_panel());
- browser = Browser::CreateWithParams(
+ browser = new Browser(
Browser::CreateParams::CreateForApp(Browser::TYPE_POPUP,
browser->app_name(),
gfx::Rect(),
browser->profile()));
} else if (browser->is_type_popup()) {
- browser = Browser::CreateWithParams(
+ browser = new Browser(
Browser::CreateParams(Browser::TYPE_POPUP, browser->profile()));
}
@@ -547,7 +547,7 @@
content::RecordAction(UserMetricsAction("ShowAsTab"));
TabContents* contents =
browser->tab_strip_model()->DetachTabContentsAt(browser->active_index());
- Browser* b = Browser::Create(browser->profile());
+ Browser* b = new Browser(Browser::CreateParams(browser->profile()));
b->tab_strip_model()->AppendTabContents(contents, true);
b->window()->Show();
}
@@ -926,7 +926,7 @@
view_source_contents,
add_types);
} else {
- Browser* b = Browser::CreateWithParams(
+ Browser* b = new Browser(
Browser::CreateParams(Browser::TYPE_TABBED, browser->profile()));
// Preserve the size of the original window. The new window has already
@@ -977,7 +977,7 @@
if (index >= 0)
browser->tab_strip_model()->DetachTabContentsAt(index);
- Browser* app_browser = Browser::CreateWithParams(
+ Browser* app_browser = new Browser(
Browser::CreateParams::CreateForApp(
Browser::TYPE_POPUP, app_name, gfx::Rect(), browser->profile()));
TabContents* tab_contents = TabContents::FromWebContents(contents);
« no previous file with comments | « chrome/browser/ui/browser_close_browsertest.cc ('k') | chrome/browser/ui/browser_finder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698