Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5084)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/enrollment_dialog_view.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/captive_portal/captive_portal_browsertest.cc ('k') | chrome/browser/chromeos/media/media_player.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/enrollment_dialog_view.cc
===================================================================
--- chrome/browser/chromeos/enrollment_dialog_view.cc (revision 148382)
+++ chrome/browser/chromeos/enrollment_dialog_view.cc (working copy)
@@ -108,11 +108,12 @@
}
bool EnrollmentDialogView::Accept() {
+ // TODO(beng): use Navigate().
// Navigate to the target URI in a browser tab.
Browser* browser = browser::FindTabbedBrowser(profile_, false);
if (!browser) {
// Couldn't find a tabbed browser: create one.
- browser = Browser::Create(profile_);
+ browser = new Browser(Browser::CreateParams(profile_));
}
DCHECK(browser);
chrome::AddSelectedTabWithURL(browser, target_uri_,
« no previous file with comments | « chrome/browser/captive_portal/captive_portal_browsertest.cc ('k') | chrome/browser/chromeos/media/media_player.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698