Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/ui/cocoa/cocoa_profile_test.mm

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/cocoa_profile_test.mm
===================================================================
--- chrome/browser/ui/cocoa/cocoa_profile_test.mm (revision 148382)
+++ chrome/browser/ui/cocoa/cocoa_profile_test.mm (working copy)
@@ -71,7 +71,7 @@
AutocompleteClassifierFactory::GetInstance()->SetTestingFactoryAndUse(
profile_, &AutocompleteClassifierFactory::BuildInstanceFor);
- browser_.reset(new Browser(Browser::TYPE_TABBED, profile_));
+ browser_.reset(CreateBrowser());
ASSERT_TRUE(browser_.get());
}
@@ -82,11 +82,6 @@
CocoaTest::TearDown();
}
-BrowserWindow* CocoaProfileTest::CreateBrowserWindow() {
- browser_->InitBrowserWindow();
- return browser_->window();
-}
-
void CocoaProfileTest::CloseBrowserWindow() {
// Check to make sure a window was actually created.
DCHECK(browser_->window());
@@ -95,3 +90,7 @@
// |browser_| will be deleted by its BrowserWindowController.
ignore_result(browser_.release());
}
+
+Browser* CocoaProfileTest::CreateBrowser() {
+ return new Browser(Browser::CreateParams(profile()));
+}

Powered by Google App Engine
This is Rietveld 408576698