Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2175)

Unified Diff: chrome/browser/ui/tabs/pinned_tab_service_unittest.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tabs/pinned_tab_service_unittest.cc
===================================================================
--- chrome/browser/ui/tabs/pinned_tab_service_unittest.cc (revision 148382)
+++ chrome/browser/ui/tabs/pinned_tab_service_unittest.cc (working copy)
@@ -52,10 +52,9 @@
browser()->tab_strip_model()->SetTabPinned(0, true);
// Create a popup.
- scoped_ptr<Browser> popup(new Browser(Browser::TYPE_POPUP, profile()));
- scoped_ptr<TestBrowserWindow> popup_window(
- new TestBrowserWindow(popup.get()));
- popup->SetWindowForTesting(popup_window.get());
+ Browser::CreateParams params(Browser::TYPE_POPUP, profile());
+ scoped_ptr<Browser> popup(
+ chrome::CreateBrowserWithTestWindowForParams(&params));
// Close the browser. This should trigger saving the tabs. No need to destroy
// the browser (this happens automatically in the test destructor).
@@ -68,7 +67,6 @@
// Close the popup. This shouldn't reset the saved state.
chrome::CloseAllTabs(popup.get());
popup.reset(NULL);
- popup_window.reset(NULL);
// Check the state to make sure it hasn't changed.
result = PinnedTabTestUtils::TabsToString(

Powered by Google App Engine
This is Rietveld 408576698