Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/debugger/devtools_window.cc ('k') | chrome/browser/extensions/api/identity/identity_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
===================================================================
--- chrome/browser/extensions/api/extension_action/browser_action_apitest.cc (revision 148382)
+++ chrome/browser/extensions/api/extension_action/browser_action_apitest.cc (working copy)
@@ -295,7 +295,8 @@
// Open an incognito window and test that the browser action isn't there by
// default.
Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();
- Browser* incognito_browser = Browser::Create(incognito_profile);
+ Browser* incognito_browser =
+ new Browser(Browser::CreateParams(incognito_profile));
ASSERT_EQ(0,
BrowserActionTestUtil(incognito_browser).NumberOfBrowserActions());
@@ -307,7 +308,7 @@
SetIsIncognitoEnabled(extension->id(), true);
chrome::CloseWindow(incognito_browser);
- incognito_browser = Browser::Create(incognito_profile);
+ incognito_browser = new Browser(Browser::CreateParams(incognito_profile));
ASSERT_EQ(1,
BrowserActionTestUtil(incognito_browser).NumberOfBrowserActions());
@@ -345,7 +346,8 @@
service->extension_prefs()->SetIsIncognitoEnabled(extension_c->id(), true);
Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();
- Browser* incognito_browser = Browser::Create(incognito_profile);
+ Browser* incognito_browser =
+ new Browser(Browser::CreateParams(incognito_profile));
BrowserActionTestUtil incognito_bar(incognito_browser);
// Navigate just to have a tab in this window, otherwise wonky things happen.
« no previous file with comments | « chrome/browser/debugger/devtools_window.cc ('k') | chrome/browser/extensions/api/identity/identity_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698