Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 10407054: Fixed layout of messages.json files (Closed)

Created:
8 years, 7 months ago by Jamie
Modified:
8 years, 7 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Added missing strings and fixed layout. BUG=128572 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14784 lines, -42 lines) Patch
M remoting/webapp/_locales.official/ar/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/bg/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/ca/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/cs/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/da/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/de/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/el/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/en/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/en_GB/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/es/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/es_419/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/et/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/fi/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/fil/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/fr/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/he/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/hi/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/hr/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/hu/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/id/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/it/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/ja/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/ko/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/lt/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/lv/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/nb/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/nl/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/pl/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/pt_BR/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/pt_PT/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/ro/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/ru/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/sk/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/sl/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/sr/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/sv/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/th/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/tr/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/uk/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/vi/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/zh_CN/messages.json View 1 chunk +352 lines, -1 line 0 comments Download
M remoting/webapp/_locales.official/zh_TW/messages.json View 1 chunk +352 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Jamie
This doesn't actually add any strings--it just pretty-prints them--but I'm not sure how else to ...
8 years, 7 months ago (2012-05-19 21:05:03 UTC) #1
khositbonne
lgtm
8 years, 7 months ago (2012-05-20 01:37:13 UTC) #2
khositbonne
lgtm
8 years, 7 months ago (2012-05-20 01:37:15 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 7 months ago (2012-05-20 01:37:25 UTC) #4
Wez
lgtm Rubber-stamp...
8 years, 7 months ago (2012-05-20 02:48:56 UTC) #5
Wez
lgtm lgtm Rubber-stamp...
8 years, 7 months ago (2012-05-20 02:48:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/10407054/1
8 years, 7 months ago (2012-05-20 02:49:00 UTC) #7
commit-bot: I haz the power
Can't process patch for file remoting/webapp/_locales.official/nl/messages.json. Hunk header is incorrect: 351 vs 352
8 years, 7 months ago (2012-05-20 02:49:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/10407054/1
8 years, 7 months ago (2012-05-20 03:35:51 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-20 03:35:55 UTC) #10
Can't process patch for file remoting/webapp/_locales.official/nl/messages.json.
Hunk header is incorrect: 351 vs 352

Powered by Google App Engine
This is Rietveld 408576698