Issue 23513006: Add glTexGen funcs to interface

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -30 lines)			Patch
M	include/gpu/GrTypes.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/gl/GrGLFunctions.h	View	1 2 3 4	4 chunks	+7 lines, -0 lines	0 comments	Download
M	include/gpu/gl/GrGLInterface.h	View	1 2 3 4	4 chunks	+7 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.h	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	1 2 3 4 5	4 chunks	+12 lines, -6 lines	0 comments	Download
M	src/gpu/gl/GrGLCreateNullInterface.cpp	View	1 2 3 4	6 chunks	+11 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLDefines.h	View	1 2 3 4 5	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLInterface.cpp	View	1 2 3 4	2 chunks	+23 lines, -8 lines	0 comments	Download
M	src/gpu/gl/GrGLNoOpInterface.h	View	1 2 3 4	5 chunks	+18 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLNoOpInterface.cpp	View	1 2 3 4	6 chunks	+30 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 2 3 4 5 6 7 8	2 chunks	+27 lines, -8 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	1 2 3 4 5 6 7 8	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/gpu/gl/debug/GrGLCreateDebugInterface.cpp	View	1 2 3 4	6 chunks	+17 lines, -0 lines	0 comments	Download
M	src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp	View	1 2 3 4 5 6 7 8 9	4 chunks	+7 lines, -0 lines	0 comments	Download
M	src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp	View	1 2 3 4 5 6 7 8 9 10	5 chunks	+10 lines, -0 lines	0 comments	Download
M	src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp	View	1 2 3 4	4 chunks	+7 lines, -0 lines	0 comments	Download
M	src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp	View	1 2 3 4 5 6	4 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

robertphillips

LGTM - do we care about the other interfaces (e.g., debug or null)?

7 years, 3 months ago (2013-08-28 21:55:42 UTC) #4

bsalomon

On 2013/08/28 21:55:42, robertphillips wrote: > LGTM - do we care about the other interfaces ...

7 years, 3 months ago (2013-08-28 22:11:59 UTC) #5

bsalomon

I think this is ready now. I added more functions, added them to the debug/null ...

7 years, 3 months ago (2013-08-29 19:10:44 UTC) #6

robertphillips

lgtm + 1 naming question https://codereview.chromium.org/23513006/diff/41001/src/gpu/gl/GrGpuGL.h File src/gpu/gl/GrGpuGL.h (right): https://codereview.chromium.org/23513006/diff/41001/src/gpu/gl/GrGpuGL.h#newcode419 src/gpu/gl/GrGpuGL.h:419: fixed -> Fixed?

7 years, 3 months ago (2013-08-29 19:22:55 UTC) #7

bsalomon

https://codereview.chromium.org/23513006/diff/41001/src/gpu/gl/GrGpuGL.h File src/gpu/gl/GrGpuGL.h (right): https://codereview.chromium.org/23513006/diff/41001/src/gpu/gl/GrGpuGL.h#newcode419 src/gpu/gl/GrGpuGL.h:419: On 2013/08/29 19:22:56, robertphillips wrote: > fixed -> Fixed? ...

7 years, 3 months ago (2013-08-29 19:25:23 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23513006/41002

7 years, 3 months ago (2013-08-30 13:13:54 UTC) #10

Message was sent while issue was closed.

Change committed as 11032

Expand Messages | Collapse Messages

Issue 23513006: Add glTexGen funcs to interface (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix sig #

Patch Set 3 : Add vertex pointer #

Patch Set 4 : Add clients state disable / enable #

Patch Set 5 : more functions, null&debug, onResetContext #

Patch Set 6 : cleanup #

Patch Set 7 : glClientActiveTexture is not in OGL 1.1, use wglGetProcAddress #

Patch Set 8 : fix name at Rob's suggestion #

Patch Set 9 : more cleanup #

Patch Set 10 : fix mac #

Patch Set 11 : mesa #

Messages