[Sync] Move 'sync' target to sync/

[Sync] Move 'sync' target to sync/

Also move related test files.

Move WriteNode::UpdateEntryWithEncryption to nigori_util.h.

Clean up defines and dependencies.  In particular, get rid of SYNC_ENGINE_VERSION_STRING and hard-code the string in the single place it's used.

Rename data_encryption.* to data_encryption_win.* and add a pragma for crypt32.lib.

Clean up exit-time constructor warnings in sync{able,er}_unittest.cc.

Remove some unused files.

BUG=117585
TEST=
TBR=jhawkins@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126872

[akalin, 2012-03-15 05:13:32]

+tim for review (sorry)

There are a lot (a lot!) of files that are touched, but 90% of the changes are
changes to #includes or header guards.

Suggested review order:
- sync/sync.gyp
- new DEPS files in sync/
- changes to DEPS files in chrome/sync
- All the touched files outside of chrome/sync and sync/
- If you're bored, you could go through each modified file and make sure there
are no other changes but #includes and header guards (or the changes described
in the CL description).

[akalin, 2012-03-15 06:07:27]

Uploaded a new patch, but it's just some trivial fixes to fix compile warnings /
link errors.

[tim (not reviewing), 2012-03-15 06:21:10]

It's almost like you used a script or two :)

A few comments, but this LGTM.  I think I'm most excited to have way less to
type in vi now :)

+Richard since I had a question about InMemoryDirectoryBackingStore.

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/browser/sync/...
File chrome/browser/sync/DEPS (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/browser/sync/...
chrome/browser/sync/DEPS:5: # For files not in a subdirectory (what a mess!).
At least it's getting closer to being the *only* mess!

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/browser/sync/...
File chrome/browser/sync/glue/DEPS (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/browser/sync/...
chrome/browser/sync/glue/DEPS:32: "+sync/syncable/directory_manager.h",
wait... have you synced to head? directory_manager is no more!

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/browser/sync/...
File chrome/browser/sync/internal_api/all_status.cc (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/browser/sync/...
chrome/browser/sync/internal_api/all_status.cc:5: #include
"chrome/browser/sync/internal_api/all_status.h"
I guess this does feel more at home here in /internal_api.  My mind is somewhat
blown.

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/chrome_tests....
File chrome/chrome_tests.gypi (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/chrome_tests....
chrome/chrome_tests.gypi:3674: ['OS=="linux" and linux_use_tcmalloc==1', {
where did this come from?

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/DEPS
File sync/DEPS (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/DEPS#newcode12
sync/DEPS:12: "-sync",
Never thought of this. Nifty.

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/protocol/proto_...
File sync/protocol/proto_value_conversions.cc (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/protocol/proto_...
sync/protocol/proto_value_conversions.cc:25: #include
"sync/protocol/proto_enum_conversions.h"
script fail!!

Well, I guess it's garbage-in-garbage-out.

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/syncable/direct...
File sync/syncable/directory_backing_store.cc (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/syncable/direct...
sync/syncable/directory_backing_store.cc:973: // actually use it for something.)
File bug to track?

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/syncable/in_mem...
File sync/syncable/in_memory_directory_backing_store.h (left):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/syncable/in_mem...
sync/syncable/in_memory_directory_backing_store.h:5: #ifndef
CHROME_BROWSER_SYNC_SYNCABLE_IN_MEMORY_DIRECTORY_BACKING_STORE_H_
curious... if this is test only, why isn't it part of TestDirectoryBackingStore
(or at least, somehow named / located in a test-specific way)?  It's unclear
this isn't production code, which.. is not ideal (There's a presubmit warning
for a related situation where you call test code from production code. I think
this totally evades that warning).

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/DEPS
File sync/util/DEPS (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/DEPS#newcode3
sync/util/DEPS:3: "+sync/util",
Is this really needed? You don't seem to have to do this elsewhere (engine,
syncable)...

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/cryptograp...
File sync/util/cryptographer.cc (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/cryptograp...
sync/util/cryptographer.cc:9: #include "sync/util/cryptographer.h"
this should go at top.

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/protobuf_u...
File sync/util/protobuf_unittest.cc (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/protobuf_u...
sync/util/protobuf_unittest.cc:3: // found in the LICENSE file.
don't see any changes to this file

[akalin, 2012-03-15 07:38:26]

Checking in as soon as tests pass. (Hopefully tonight)

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/browser/sync/...
File chrome/browser/sync/glue/DEPS (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/browser/sync/...
chrome/browser/sync/glue/DEPS:32: "+sync/syncable/directory_manager.h",
On 2012/03/15 06:21:10, timsteele wrote:
> wait... have you synced to head? directory_manager is no more!

Removed!  I guess this DEP wasn't properly removed when directory_manager itself
was.

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/chrome_tests....
File chrome/chrome_tests.gypi (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/chrome/chrome_tests....
chrome/chrome_tests.gypi:3674: ['OS=="linux" and linux_use_tcmalloc==1', {
On 2012/03/15 06:21:10, timsteele wrote:
> where did this come from?

It's needed because of our use of histograms.  I guess we were pulling it in
indirectly some other way before (?).  Added comment/TODO explaining.

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/protocol/proto_...
File sync/protocol/proto_value_conversions.cc (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/protocol/proto_...
sync/protocol/proto_value_conversions.cc:25: #include
"sync/protocol/proto_enum_conversions.h"
On 2012/03/15 06:21:10, timsteele wrote:
> script fail!!
> 
> Well, I guess it's garbage-in-garbage-out.

wait...I don't see what's wrong?  I'll submit anyway; let me know if there is
indeed something I should do.

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/syncable/direct...
File sync/syncable/directory_backing_store.cc (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/syncable/direct...
sync/syncable/directory_backing_store.cc:973: // actually use it for something.)
On 2012/03/15 06:21:10, timsteele wrote:
> File bug to track?

Done.

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/syncable/in_mem...
File sync/syncable/in_memory_directory_backing_store.h (left):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/syncable/in_mem...
sync/syncable/in_memory_directory_backing_store.h:5: #ifndef
CHROME_BROWSER_SYNC_SYNCABLE_IN_MEMORY_DIRECTORY_BACKING_STORE_H_
On 2012/03/15 06:21:10, timsteele wrote:
> curious... if this is test only, why isn't it part of
TestDirectoryBackingStore
> (or at least, somehow named / located in a test-specific way)?  It's unclear
> this isn't production code, which.. is not ideal (There's a presubmit warning
> for a related situation where you call test code from production code. I think
> this totally evades that warning).

Well, it's pulled into production code (from syncable.cc) because we use that
setup_for_test flag (see
http://code.google.com/p/chromium/issues/detail?id=117836).  Although I guess
renaming it to be something like InMemoryDirectoryBackingStoreForTest would be
okay, although a bit unwieldy.

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/DEPS
File sync/util/DEPS (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/DEPS#newcode3
sync/util/DEPS:3: "+sync/util",
On 2012/03/15 06:21:10, timsteele wrote:
> Is this really needed? You don't seem to have to do this elsewhere (engine,
> syncable)...

Done.  It's not needed; I don't know why I put it there.

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/cryptograp...
File sync/util/cryptographer.cc (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/cryptograp...
sync/util/cryptographer.cc:9: #include "sync/util/cryptographer.h"
On 2012/03/15 06:21:10, timsteele wrote:
> this should go at top.

Done.

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/protobuf_u...
File sync/util/protobuf_unittest.cc (right):

https://chromiumcodereview.appspot.com/9699057/diff/2446/sync/util/protobuf_u...
sync/util/protobuf_unittest.cc:3: // found in the LICENSE file.
On 2012/03/15 06:21:10, timsteele wrote:
> don't see any changes to this file

Right.  I think it only shows up because the file was moved (and it's a one of
the rare (only?) files that doesn't actually need any code change)

[akalin, 2012-03-15 09:33:47]

+jhawkins for review/TBR

[akalin, 2012-03-15 09:34:33]

TBRing this as webui changes are just include/DEPS changes