Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5463)

Unified Diff: chrome/browser/sync/engine/syncer_proto_util.h

Issue 9699057: [Sync] Move 'sync' target to sync/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Tim's comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/syncer_command.cc ('k') | chrome/browser/sync/engine/syncer_proto_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/syncer_proto_util.h
diff --git a/chrome/browser/sync/engine/syncer_proto_util.h b/chrome/browser/sync/engine/syncer_proto_util.h
deleted file mode 100644
index e9d3c79bd1fa404e4914562ed5830a0f53adda11..0000000000000000000000000000000000000000
--- a/chrome/browser/sync/engine/syncer_proto_util.h
+++ /dev/null
@@ -1,138 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_SYNC_ENGINE_SYNCER_PROTO_UTIL_H_
-#define CHROME_BROWSER_SYNC_ENGINE_SYNCER_PROTO_UTIL_H_
-#pragma once
-
-#include <string>
-
-#include "base/gtest_prod_util.h"
-#include "base/time.h"
-#include "chrome/browser/sync/internal_api/includes/syncer_error.h"
-#include "chrome/browser/sync/sessions/sync_session.h"
-#include "chrome/browser/sync/syncable/blob.h"
-#include "chrome/browser/sync/syncable/model_type.h"
-
-namespace syncable {
-class Directory;
-class Entry;
-} // namespace syncable
-
-namespace sync_pb {
-class ClientToServerResponse;
-class EntitySpecifics;
-} // namespace sync_pb
-
-namespace browser_sync {
-
-namespace sessions {
-class SyncProtocolError;
-class SyncSessionContext;
-}
-
-class ClientToServerMessage;
-class ServerConnectionManager;
-class SyncEntity;
-class CommitResponse_EntryResponse;
-
-class SyncerProtoUtil {
- public:
- // Posts the given message and fills the buffer with the returned value.
- // Returns true on success. Also handles store birthday verification: will
- // produce a SyncError if the birthday is incorrect.
- static SyncerError PostClientToServerMessage(
- const ClientToServerMessage& msg,
- sync_pb::ClientToServerResponse* response,
- sessions::SyncSession* session);
-
- // Compares a syncable Entry to SyncEntity, returns true iff the data is
- // identical.
- //
- // TODO(sync): The places where this function is used are arguable big causes
- // of the fragility, because there's a tendency to freak out the moment the
- // local and server values diverge. However, this almost always indicates a
- // sync bug somewhere earlier in the sync cycle.
- static bool Compare(const syncable::Entry& local_entry,
- const SyncEntity& server_entry);
-
- // Utility methods for converting between syncable::Blobs and protobuf byte
- // fields.
- static void CopyProtoBytesIntoBlob(const std::string& proto_bytes,
- syncable::Blob* blob);
- static bool ProtoBytesEqualsBlob(const std::string& proto_bytes,
- const syncable::Blob& blob);
- static void CopyBlobIntoProtoBytes(const syncable::Blob& blob,
- std::string* proto_bytes);
-
- // Extract the name field from a sync entity.
- static const std::string& NameFromSyncEntity(
- const sync_pb::SyncEntity& entry);
-
- // Extract the name field from a commit entry response.
- static const std::string& NameFromCommitEntryResponse(
- const CommitResponse_EntryResponse& entry);
-
- // EntitySpecifics is used as a filter for the GetUpdates message to tell
- // the server which datatypes to send back. This adds a datatype so that
- // it's included in the filter.
- static void AddToEntitySpecificDatatypesFilter(syncable::ModelType datatype,
- sync_pb::EntitySpecifics* filter);
-
- // Get a debug string representation of the client to server response.
- static std::string ClientToServerResponseDebugString(
- const sync_pb::ClientToServerResponse& response);
-
- // Get update contents as a string. Intended for logging, and intended
- // to have a smaller footprint than the protobuf's built-in pretty printer.
- static std::string SyncEntityDebugString(const sync_pb::SyncEntity& entry);
-
- // Pull the birthday from the dir and put it into the msg.
- static void AddRequestBirthday(syncable::Directory* dir,
- ClientToServerMessage* msg);
-
- private:
- SyncerProtoUtil() {}
-
- // Helper functions for PostClientToServerMessage.
-
- // Verifies the store birthday, alerting/resetting as appropriate if there's a
- // mismatch. Return false if the syncer should be stuck.
- static bool VerifyResponseBirthday(syncable::Directory* dir,
- const sync_pb::ClientToServerResponse* response);
-
- // Builds and sends a SyncEngineEvent to begin migration for types (specified
- // in notification).
- static void HandleMigrationDoneResponse(
- const sync_pb::ClientToServerResponse* response,
- sessions::SyncSession* session);
-
- // Post the message using the scm, and do some processing on the returned
- // headers. Decode the server response.
- static bool PostAndProcessHeaders(browser_sync::ServerConnectionManager* scm,
- sessions::SyncSession* session,
- const ClientToServerMessage& msg,
- sync_pb::ClientToServerResponse* response);
-
- static base::TimeDelta GetThrottleDelay(
- const sync_pb::ClientToServerResponse& response);
-
- static void HandleThrottleError(const SyncProtocolError& error,
- const base::TimeTicks& throttled_until,
- sessions::SyncSessionContext* context,
- sessions::SyncSession::Delegate* delegate);
-
- friend class SyncerProtoUtilTest;
- FRIEND_TEST_ALL_PREFIXES(SyncerProtoUtilTest, AddRequestBirthday);
- FRIEND_TEST_ALL_PREFIXES(SyncerProtoUtilTest, PostAndProcessHeaders);
- FRIEND_TEST_ALL_PREFIXES(SyncerProtoUtilTest, VerifyResponseBirthday);
- FRIEND_TEST_ALL_PREFIXES(SyncerProtoUtilTest, HandleThrottlingNoDatatypes);
- FRIEND_TEST_ALL_PREFIXES(SyncerProtoUtilTest, HandleThrottlingWithDatatypes);
-
- DISALLOW_COPY_AND_ASSIGN(SyncerProtoUtil);
-};
-
-} // namespace browser_sync
-
-#endif // CHROME_BROWSER_SYNC_ENGINE_SYNCER_PROTO_UTIL_H_
« no previous file with comments | « chrome/browser/sync/engine/syncer_command.cc ('k') | chrome/browser/sync/engine/syncer_proto_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698