Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/sync/protocol/proto_value_conversions_unittest.cc

Issue 9699057: [Sync] Move 'sync' target to sync/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Tim's comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/protocol/proto_value_conversions_unittest.cc
diff --git a/chrome/browser/sync/protocol/proto_value_conversions_unittest.cc b/chrome/browser/sync/protocol/proto_value_conversions_unittest.cc
deleted file mode 100644
index 005c267c6deb0bbb6bbcd8a4765a9e50c89ecf56..0000000000000000000000000000000000000000
--- a/chrome/browser/sync/protocol/proto_value_conversions_unittest.cc
+++ /dev/null
@@ -1,191 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// Keep this file in sync with the .proto files in this directory.
-
-#include "chrome/browser/sync/protocol/proto_value_conversions.h"
-
-#include "base/memory/scoped_ptr.h"
-#include "base/values.h"
-#include "chrome/browser/sync/syncable/model_type.h"
-#include "sync/protocol/app_notification_specifics.pb.h"
-#include "sync/protocol/app_setting_specifics.pb.h"
-#include "sync/protocol/app_specifics.pb.h"
-#include "sync/protocol/autofill_specifics.pb.h"
-#include "sync/protocol/bookmark_specifics.pb.h"
-#include "sync/protocol/encryption.pb.h"
-#include "sync/protocol/extension_setting_specifics.pb.h"
-#include "sync/protocol/extension_specifics.pb.h"
-#include "sync/protocol/nigori_specifics.pb.h"
-#include "sync/protocol/password_specifics.pb.h"
-#include "sync/protocol/preference_specifics.pb.h"
-#include "sync/protocol/search_engine_specifics.pb.h"
-#include "sync/protocol/session_specifics.pb.h"
-#include "sync/protocol/sync.pb.h"
-#include "sync/protocol/theme_specifics.pb.h"
-#include "sync/protocol/typed_url_specifics.pb.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace browser_sync {
-namespace {
-
-class ProtoValueConversionsTest : public testing::Test {
- protected:
- template <class T>
- void TestSpecificsToValue(
- DictionaryValue* (*specifics_to_value)(const T&)) {
- const T& specifics(T::default_instance());
- scoped_ptr<DictionaryValue> value(specifics_to_value(specifics));
- // We can't do much but make sure that the returned value has
- // something in it.
- EXPECT_FALSE(value->empty());
- }
-};
-
-TEST_F(ProtoValueConversionsTest, ProtoChangeCheck) {
- // If this number changes, that means we added or removed a data
- // type. Don't forget to add a unit test for {New
- // type}SpecificsToValue below.
- EXPECT_EQ(17, syncable::MODEL_TYPE_COUNT);
-
- // We'd also like to check if we changed any field in our messages.
- // However, that's hard to do: sizeof could work, but it's
- // platform-dependent. default_instance().ByteSize() won't change
- // for most changes, since most of our fields are optional. So we
- // just settle for comments in the proto files.
-}
-
-TEST_F(ProtoValueConversionsTest, EncryptedDataToValue) {
- TestSpecificsToValue(EncryptedDataToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, SessionHeaderToValue) {
- TestSpecificsToValue(SessionHeaderToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, SessionTabToValue) {
- TestSpecificsToValue(SessionTabToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, SessionWindowToValue) {
- TestSpecificsToValue(SessionWindowToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, TabNavigationToValue) {
- TestSpecificsToValue(TabNavigationToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, PasswordSpecificsData) {
- sync_pb::PasswordSpecificsData specifics;
- specifics.set_password_value("secret");
- scoped_ptr<DictionaryValue> value(PasswordSpecificsDataToValue(specifics));
- EXPECT_FALSE(value->empty());
- std::string password_value;
- EXPECT_TRUE(value->GetString("password_value", &password_value));
- EXPECT_EQ("<redacted>", password_value);
-}
-
-TEST_F(ProtoValueConversionsTest, AppNotificationToValue) {
- TestSpecificsToValue(AppNotificationToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, AppSettingSpecificsToValue) {
- sync_pb::AppNotificationSettings specifics;
- specifics.set_disabled(true);
- specifics.set_oauth_client_id("some_id_value");
- scoped_ptr<DictionaryValue> value(AppSettingsToValue(specifics));
- EXPECT_FALSE(value->empty());
- bool disabled_value = false;
- std::string oauth_client_id_value;
- EXPECT_TRUE(value->GetBoolean("disabled", &disabled_value));
- EXPECT_EQ(true, disabled_value);
- EXPECT_TRUE(value->GetString("oauth_client_id", &oauth_client_id_value));
- EXPECT_EQ("some_id_value", oauth_client_id_value);
-}
-
-TEST_F(ProtoValueConversionsTest, AppSpecificsToValue) {
- TestSpecificsToValue(AppSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, AutofillSpecificsToValue) {
- TestSpecificsToValue(AutofillSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, AutofillProfileSpecificsToValue) {
- TestSpecificsToValue(AutofillProfileSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, BookmarkSpecificsToValue) {
- TestSpecificsToValue(BookmarkSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, ExtensionSettingSpecificsToValue) {
- TestSpecificsToValue(ExtensionSettingSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, ExtensionSpecificsToValue) {
- TestSpecificsToValue(ExtensionSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, NigoriSpecificsToValue) {
- TestSpecificsToValue(NigoriSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, PasswordSpecificsToValue) {
- TestSpecificsToValue(PasswordSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, PreferenceSpecificsToValue) {
- TestSpecificsToValue(PreferenceSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, SearchEngineSpecificsToValue) {
- TestSpecificsToValue(SearchEngineSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, SessionSpecificsToValue) {
- TestSpecificsToValue(SessionSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, ThemeSpecificsToValue) {
- TestSpecificsToValue(ThemeSpecificsToValue);
-}
-
-TEST_F(ProtoValueConversionsTest, TypedUrlSpecificsToValue) {
- TestSpecificsToValue(TypedUrlSpecificsToValue);
-}
-
-// TODO(akalin): Figure out how to better test EntitySpecificsToValue.
-
-TEST_F(ProtoValueConversionsTest, EntitySpecificsToValue) {
- sync_pb::EntitySpecifics specifics;
- // Touch the extensions to make sure it shows up in the generated
- // value.
-#define SET_FIELD(key) (void)specifics.mutable_##key()
-
- SET_FIELD(app);
- SET_FIELD(app_notification);
- SET_FIELD(app_setting);
- SET_FIELD(autofill);
- SET_FIELD(autofill_profile);
- SET_FIELD(bookmark);
- SET_FIELD(extension);
- SET_FIELD(extension_setting);
- SET_FIELD(nigori);
- SET_FIELD(password);
- SET_FIELD(preference);
- SET_FIELD(search_engine);
- SET_FIELD(session);
- SET_FIELD(theme);
- SET_FIELD(typed_url);
-
-#undef SET_FIELD
-
- scoped_ptr<DictionaryValue> value(EntitySpecificsToValue(specifics));
- EXPECT_EQ(syncable::MODEL_TYPE_COUNT - syncable::FIRST_REAL_MODEL_TYPE,
- static_cast<int>(value->size()));
-}
-
-} // namespace
-} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/protocol/proto_value_conversions.cc ('k') | chrome/browser/sync/protocol/service_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698