Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: chrome/browser/sync/engine/all_status.h

Issue 9699057: [Sync] Move 'sync' target to sync/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Tim's comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/DEPS ('k') | chrome/browser/sync/engine/all_status.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/all_status.h
diff --git a/chrome/browser/sync/engine/all_status.h b/chrome/browser/sync/engine/all_status.h
deleted file mode 100644
index aa234becfff9f7a26c279f8e9550329115049159..0000000000000000000000000000000000000000
--- a/chrome/browser/sync/engine/all_status.h
+++ /dev/null
@@ -1,86 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-//
-// The AllStatus object watches various sync engine components and aggregates
-// the status of all of them into one place.
-
-#ifndef CHROME_BROWSER_SYNC_ENGINE_ALL_STATUS_H_
-#define CHROME_BROWSER_SYNC_ENGINE_ALL_STATUS_H_
-#pragma once
-
-#include <map>
-
-#include "base/compiler_specific.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/synchronization/lock.h"
-#include "chrome/browser/sync/engine/syncer_types.h"
-#include "chrome/browser/sync/internal_api/sync_manager.h"
-#include "chrome/browser/sync/syncable/model_type.h"
-
-namespace browser_sync {
-
-class ScopedStatusLock;
-struct ServerConnectionEvent;
-
-// TODO(rlarocque):
-// Most of this data ends up on the about:sync page. But the page is only
-// 'pinged' to update itself at the end of a sync cycle. A user could refresh
-// manually, but unless their timing is excellent it's unlikely that a user will
-// see any state in mid-sync cycle. We have no plans to change this.
-//
-// What we do intend to do is improve the UI so that changes following a sync
-// cycle are more visible. Without such a change, the status summary for a
-// healthy syncer will constantly display as "READY" and never provide any
-// indication of a sync cycle being performed. See crbug.com/108100.
-
-class AllStatus : public SyncEngineEventListener {
- friend class ScopedStatusLock;
- public:
- AllStatus();
- virtual ~AllStatus();
-
- void HandleServerConnectionEvent(const ServerConnectionEvent& event);
-
- virtual void OnSyncEngineEvent(const SyncEngineEvent& event) OVERRIDE;
-
- sync_api::SyncManager::Status status() const;
-
- void SetNotificationsEnabled(bool notifications_enabled);
-
- void IncrementNotifiableCommits();
-
- void IncrementNotificationsReceived();
-
- void SetEncryptedTypes(syncable::ModelTypeSet types);
- void SetCryptographerReady(bool ready);
- void SetCryptoHasPendingKeys(bool has_pending_keys);
-
- void SetUniqueId(const std::string& guid);
-
- protected:
- // Examines syncer to calculate syncing and the unsynced count,
- // and returns a Status with new values.
- sync_api::SyncManager::Status CalcSyncing(const SyncEngineEvent& event) const;
- sync_api::SyncManager::Status CreateBlankStatus() const;
-
- // Examines status to see what has changed, updates old_status in place.
- void CalcStatusChanges();
-
- sync_api::SyncManager::Status status_;
-
- mutable base::Lock mutex_; // Protects all data members.
- DISALLOW_COPY_AND_ASSIGN(AllStatus);
-};
-
-class ScopedStatusLock {
- public:
- explicit ScopedStatusLock(AllStatus* allstatus);
- ~ScopedStatusLock();
- protected:
- AllStatus* allstatus_;
-};
-
-} // namespace browser_sync
-
-#endif // CHROME_BROWSER_SYNC_ENGINE_ALL_STATUS_H_
« no previous file with comments | « chrome/browser/sync/engine/DEPS ('k') | chrome/browser/sync/engine/all_status.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698