Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node* (Closed)

Created:
3 years, 5 months ago by yosin_UTC9
Modified:
3 years, 5 months ago
Reviewers:
yoichio, Xiaocheng
CC:
Xiaocheng, blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Position::LastPositionInNode() to take const Node& instead of Node* This patch makes |Position::LastPositionInNode()| to take |const Node&| instead of |Node*| since |Node| parameter can not be nullptr for improving code health. This patch is a preparation of make |Position| to hold |const Node&|[1] and similar to the patch[2] which change |BeforeNode()|. [1] http://crbug.com/735327 Position should hold const Node instead of Node [2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node& instead of Node* BUG=734849 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2962473002 Cr-Commit-Position: refs/heads/master@{#482496} Committed: https://chromium.googlesource.com/chromium/src/+/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377

Patch Set 1 : 2017-06-26T14:00:00 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -61 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EphemeralRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Position.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PositionTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SurroundingText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/TextFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp View 9 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/ColdModeSpellCheckRequester.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 5 months ago (2017-06-26 08:06:35 UTC) #7
Xiaocheng
lgtm
3 years, 5 months ago (2017-06-26 17:49:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962473002/1
3 years, 5 months ago (2017-06-27 01:16:12 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 01:30:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a61dd9f37830bdf66fdcc6fb9c3...

Powered by Google App Engine
This is Rietveld 408576698