Make Position::LastPositionInNode() to take const Node& instead of Node*
This patch makes |Position::LastPositionInNode()| to take |const Node&| instead
of |Node*| since |Node| parameter can not be nullptr for improving code health.
This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.
[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*
BUG=734849
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2962473002
Cr-Commit-Position: refs/heads/master@{#482496}
Committed: https://chromium.googlesource.com/chromium/src/+/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377
Description was changed from ========== 2017-06-26T14:00:00 BUG= 2017-06-26T13:59:21 ========== to ========== Make Position::LastPositionInNode() to take ...
3 years, 5 months ago
(2017-06-26 05:01:56 UTC)
#1
Description was changed from
==========
2017-06-26T14:00:00
BUG=
2017-06-26T13:59:21
==========
to
==========
Make Position::LastPositionInNode() to take const Node& instead of Node*
This patch makes |Position::LastPositionInNode()| to take |const Node&| instead
of |Node*| since |Node| parameter can not be nullptr for improving code health.
This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.
[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*
BUG=734849
TEST=n/a; no behavior changes
==========
yosin_UTC9
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
3 years, 5 months ago
(2017-06-26 05:02:25 UTC)
#2
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1498526143994640, "parent_rev": "6e84e7643da78ca93373487c5e8dfec261933fbb", "commit_rev": "5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377"}
3 years, 5 months ago
(2017-06-27 01:29:58 UTC)
#11
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1498526143994640, "parent_rev":
"6e84e7643da78ca93373487c5e8dfec261933fbb", "commit_rev":
"5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377"}
commit-bot: I haz the power
Description was changed from ========== Make Position::LastPositionInNode() to take const Node& instead of Node* This ...
3 years, 5 months ago
(2017-06-27 01:30:10 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
Make Position::LastPositionInNode() to take const Node& instead of Node*
This patch makes |Position::LastPositionInNode()| to take |const Node&| instead
of |Node*| since |Node| parameter can not be nullptr for improving code health.
This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.
[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*
BUG=734849
TEST=n/a; no behavior changes
==========
to
==========
Make Position::LastPositionInNode() to take const Node& instead of Node*
This patch makes |Position::LastPositionInNode()| to take |const Node&| instead
of |Node*| since |Node| parameter can not be nullptr for improving code health.
This patch is a preparation of make |Position| to hold |const Node&|[1] and
similar to the patch[2] which change |BeforeNode()|.
[1] http://crbug.com/735327 Position should hold const Node instead of Node
[2] http://crbug.com/2950053002: Make Position::BeforeNode() to take const Node&
instead of Node*
BUG=734849
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2962473002
Cr-Commit-Position: refs/heads/master@{#482496}
Committed:
https://chromium.googlesource.com/chromium/src/+/5a61dd9f37830bdf66fdcc6fb9c3...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5a61dd9f37830bdf66fdcc6fb9c38a9ccf607377
3 years, 5 months ago
(2017-06-27 01:30:12 UTC)
#13
Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node*
(Closed)
Created 3 years, 5 months ago by yosin_UTC9
Modified 3 years, 5 months ago
Reviewers: Xiaocheng, yoichio
Base URL:
Comments: 0