Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-26T14:00:00 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index 868deaadf37992cf1a6fd3ded0c31678678f3ad0..e8cebb54305ab83928614143ce64092867b685ae 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -439,7 +439,7 @@ static PositionTemplate<Strategy> NextBoundaryAlgorithm(
PositionTemplate<Strategy>::EditingPositionOf(
start.AnchorNode(), start.OffsetInContainerNode());
const PositionTemplate<Strategy> search_end =
- PositionTemplate<Strategy>::LastPositionInNode(boundary);
+ PositionTemplate<Strategy>::LastPositionInNode(*boundary);
TextIteratorAlgorithm<Strategy> it(
search_start, search_end,
TextIteratorBehavior::Builder()
@@ -611,7 +611,7 @@ static VisiblePositionTemplate<Strategy> EndOfDocumentAlgorithm(
Element* doc = node->GetDocument().documentElement();
return CreateVisiblePosition(
- PositionTemplate<Strategy>::LastPositionInNode(doc));
+ PositionTemplate<Strategy>::LastPositionInNode(*doc));
}
VisiblePosition EndOfDocument(const VisiblePosition& c) {
@@ -1996,7 +1996,7 @@ static EphemeralRangeTemplate<Strategy> MakeSearchRange(
return EphemeralRangeTemplate<Strategy>();
return EphemeralRangeTemplate<Strategy>(
- pos, PositionTemplate<Strategy>::LastPositionInNode(boundary));
+ pos, PositionTemplate<Strategy>::LastPositionInNode(*boundary));
}
template <typename Strategy>

Powered by Google App Engine
This is Rietveld 408576698