Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-26T14:00:00 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp b/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
index b609a0296fbabf7c4ec309a15604577ab8e48efb..75b2ed6c63d3b9e17c58535f82d7a0c7295e3b67 100644
--- a/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
+++ b/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp
@@ -19,8 +19,8 @@ TEST_F(PositionIteratorTest, decrementWithInputElement) {
// Decrement until start of "123" from INPUT on DOM tree
PositionIterator dom_iterator(
- Position::LastPositionInNode(GetDocument().body()));
- EXPECT_EQ(Position::LastPositionInNode(GetDocument().body()),
+ Position::LastPositionInNode(*GetDocument().body()));
+ EXPECT_EQ(Position::LastPositionInNode(*GetDocument().body()),
dom_iterator.ComputePosition());
dom_iterator.Decrement();
EXPECT_EQ(Position::AfterNode(*input), dom_iterator.ComputePosition());
@@ -33,8 +33,8 @@ TEST_F(PositionIteratorTest, decrementWithInputElement) {
// Decrement until start of "123" from INPUT on flat tree
PositionIteratorInFlatTree flat_iterator(
- PositionInFlatTree::LastPositionInNode(GetDocument().body()));
- EXPECT_EQ(PositionInFlatTree::LastPositionInNode(GetDocument().body()),
+ PositionInFlatTree::LastPositionInNode(*GetDocument().body()));
+ EXPECT_EQ(PositionInFlatTree::LastPositionInNode(*GetDocument().body()),
flat_iterator.ComputePosition());
flat_iterator.Decrement();
EXPECT_EQ(PositionInFlatTree::AfterNode(*input),
@@ -56,8 +56,8 @@ TEST_F(PositionIteratorTest, decrementWithSelectElement) {
// Decrement until start of "123" from SELECT on DOM tree
PositionIterator dom_iterator(
- Position::LastPositionInNode(GetDocument().body()));
- EXPECT_EQ(Position::LastPositionInNode(GetDocument().body()),
+ Position::LastPositionInNode(*GetDocument().body()));
+ EXPECT_EQ(Position::LastPositionInNode(*GetDocument().body()),
dom_iterator.ComputePosition());
dom_iterator.Decrement();
EXPECT_EQ(Position::AfterNode(*select), dom_iterator.ComputePosition());
@@ -74,8 +74,8 @@ TEST_F(PositionIteratorTest, decrementWithSelectElement) {
// Decrement until start of "123" from SELECT on flat tree
PositionIteratorInFlatTree flat_iterator(
- PositionInFlatTree::LastPositionInNode(GetDocument().body()));
- EXPECT_EQ(PositionInFlatTree::LastPositionInNode(GetDocument().body()),
+ PositionInFlatTree::LastPositionInNode(*GetDocument().body()));
+ EXPECT_EQ(PositionInFlatTree::LastPositionInNode(*GetDocument().body()),
flat_iterator.ComputePosition());
flat_iterator.Decrement();
EXPECT_EQ(PositionInFlatTree::AfterNode(*select),
@@ -103,8 +103,8 @@ TEST_F(PositionIteratorTest, decrementWithTextAreaElement) {
// Decrement until end of "123" from after TEXTAREA on DOM tree
PositionIterator dom_iterator(
- Position::LastPositionInNode(GetDocument().body()));
- EXPECT_EQ(Position::LastPositionInNode(GetDocument().body()),
+ Position::LastPositionInNode(*GetDocument().body()));
+ EXPECT_EQ(Position::LastPositionInNode(*GetDocument().body()),
dom_iterator.ComputePosition());
dom_iterator.Decrement();
EXPECT_EQ(Position::AfterNode(*textarea), dom_iterator.ComputePosition());
@@ -117,8 +117,8 @@ TEST_F(PositionIteratorTest, decrementWithTextAreaElement) {
// Decrement until end of "123" from after TEXTAREA on flat tree
PositionIteratorInFlatTree flat_iterator(
- PositionInFlatTree::LastPositionInNode(GetDocument().body()));
- EXPECT_EQ(PositionInFlatTree::LastPositionInNode(GetDocument().body()),
+ PositionInFlatTree::LastPositionInNode(*GetDocument().body()));
+ EXPECT_EQ(PositionInFlatTree::LastPositionInNode(*GetDocument().body()),
flat_iterator.ComputePosition());
flat_iterator.Decrement();
EXPECT_EQ(PositionInFlatTree::AfterNode(*textarea),
« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.cpp ('k') | third_party/WebKit/Source/core/editing/PositionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698