third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp - Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-26T14:00:00 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

index aeae25413d2ab891185b7869502b026cf4dd93b5..114e2f15cb8b9a41adc312c362c2699ae1ab8d20 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

@@ -64,7 +64,7 @@ TEST_F(EditingUtilitiesTest, firstEditablePositionAfterPositionInRoot) {

EXPECT_EQ(PositionInFlatTree::AfterNode(*host),

FirstEditablePositionAfterPositionInRoot(

PositionInFlatTree(three, 0), *host));

- EXPECT_EQ(PositionInFlatTree::LastPositionInNode(host),

+ EXPECT_EQ(PositionInFlatTree::LastPositionInNode(*host),

FirstEditableVisiblePositionAfterPositionInRoot(

PositionInFlatTree(three, 0), *host)

.DeepEquivalent());

@@ -138,7 +138,7 @@ TEST_F(EditingUtilitiesTest, tableElementJustBefore) {

EXPECT_EQ(table,

TableElementJustBefore(VisiblePosition::LastPositionInNode(table)));

EXPECT_EQ(table, TableElementJustBefore(CreateVisiblePosition(

- PositionInFlatTree::LastPositionInNode(table))));

+ PositionInFlatTree::LastPositionInNode(*table))));

EXPECT_EQ(nullptr,

TableElementJustBefore(CreateVisiblePosition(Position(host, 2))));

@@ -152,7 +152,7 @@ TEST_F(EditingUtilitiesTest, tableElementJustBefore) {

EXPECT_EQ(nullptr,

TableElementJustBefore(VisiblePosition::LastPositionInNode(host)));

EXPECT_EQ(table, TableElementJustBefore(CreateVisiblePosition(

- PositionInFlatTree::LastPositionInNode(host))));

+ PositionInFlatTree::LastPositionInNode(*host))));

}

TEST_F(EditingUtilitiesTest, lastEditablePositionBeforePositionInRoot) {