Make Position::LastPositionInNode() to take const Node& instead of Node*

third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/VisibleSelection.h"
 
 #include "core/dom/Range.h"
 #include "core/editing/EditingTestBase.h"
 #include "core/editing/SelectionAdjuster.h"
 
@@ skipping 236 matching lines @@
 // For http://crbug.com/695317
 TEST_F(VisibleSelectionTest, SelectAllWithInputElement) {
   SetBodyContent("<input>123");
   Element* const html_element = GetDocument().documentElement();
   Element* const input = GetDocument().QuerySelector("input");
   Node* const last_child = GetDocument().body()->lastChild();
 
   const VisibleSelection& visible_selectin_in_dom_tree = CreateVisibleSelection(
       SelectionInDOMTree::Builder()
           .Collapse(Position::FirstPositionInNode(*html_element))
-          .Extend(Position::LastPositionInNode(html_element))
+          .Extend(Position::LastPositionInNode(*html_element))
           .Build());
   EXPECT_EQ(SelectionInDOMTree::Builder()
                 .Collapse(Position::BeforeNode(*input))
                 .Extend(Position(last_child, 3))
                 .Build(),
             visible_selectin_in_dom_tree.AsSelection());
 
   const VisibleSelectionInFlatTree& visible_selectin_in_flat_tree =
       CreateVisibleSelection(
           SelectionInFlatTree::Builder()
               .Collapse(PositionInFlatTree::FirstPositionInNode(*html_element))
-              .Extend(PositionInFlatTree::LastPositionInNode(html_element))
+              .Extend(PositionInFlatTree::LastPositionInNode(*html_element))
               .Build());
   EXPECT_EQ(SelectionInFlatTree::Builder()
                 .Collapse(PositionInFlatTree::BeforeNode(*input))
                 .Extend(PositionInFlatTree(last_child, 3))
                 .Build(),
             visible_selectin_in_flat_tree.AsSelection());
 }
 
 TEST_F(VisibleSelectionTest, ShadowCrossing) {
   const char* body_content =
       "<p id='host'>00<b id='one'>11</b><b id='two'>22</b>33</p>";
   const char* shadow_content =
       "<a><span id='s4'>44</span><content select=#two></content><span "
       "id='s5'>55</span><content select=#one></content><span "
       "id='s6'>66</span></a>";
   SetBodyContent(body_content);
   ShadowRoot* shadow_root = SetShadowContent(shadow_content, "host");
 
   Element* body = GetDocument().body();
   Element* host = body->QuerySelector("#host");
   Element* one = body->QuerySelector("#one");
   Element* six = shadow_root->QuerySelector("#s6");
 
   VisibleSelection selection = CreateVisibleSelection(
       SelectionInDOMTree::Builder()
           .Collapse(Position::FirstPositionInNode(*one))
-          .Extend(Position::LastPositionInNode(shadow_root))
+          .Extend(Position::LastPositionInNode(*shadow_root))
           .Build());
   VisibleSelectionInFlatTree selection_in_flat_tree = CreateVisibleSelection(
       SelectionInFlatTree::Builder()
           .Collapse(PositionInFlatTree::FirstPositionInNode(*one))
-          .Extend(PositionInFlatTree::LastPositionInNode(host))
+          .Extend(PositionInFlatTree::LastPositionInNode(*host))
           .Build());
 
   EXPECT_EQ(Position(host, PositionAnchorType::kBeforeAnchor),
             selection.Start());
   EXPECT_EQ(Position(one->firstChild(), 0), selection.End());
   EXPECT_EQ(PositionInFlatTree(one->firstChild(), 0),
             selection_in_flat_tree.Start());
   EXPECT_EQ(PositionInFlatTree(six->firstChild(), 2),
             selection_in_flat_tree.End());
 }
 
 TEST_F(VisibleSelectionTest, ShadowV0DistributedNodes) {
   const char* body_content =
       "<p id='host'>00<b id='one'>11</b><b id='two'>22</b>33</p>";
   const char* shadow_content =
       "<a><span id='s4'>44</span><content select=#two></content><span "
       "id='s5'>55</span><content select=#one></content><span "
       "id='s6'>66</span></a>";
   SetBodyContent(body_content);
   ShadowRoot* shadow_root = SetShadowContent(shadow_content, "host");
 
   Element* body = GetDocument().body();
   Element* one = body->QuerySelector("#one");
   Element* two = body->QuerySelector("#two");
   Element* five = shadow_root->QuerySelector("#s5");
 
   VisibleSelection selection =
       CreateVisibleSelection(SelectionInDOMTree::Builder()
                                  .Collapse(Position::FirstPositionInNode(*one))
-                                 .Extend(Position::LastPositionInNode(two))
+                                 .Extend(Position::LastPositionInNode(*two))
                                  .Build());
   VisibleSelectionInFlatTree selection_in_flat_tree = CreateVisibleSelection(
       SelectionInFlatTree::Builder()
           .Collapse(PositionInFlatTree::FirstPositionInNode(*one))
-          .Extend(PositionInFlatTree::LastPositionInNode(two))
+          .Extend(PositionInFlatTree::LastPositionInNode(*two))
           .Build());
 
   EXPECT_EQ(Position(one->firstChild(), 0), selection.Start());
   EXPECT_EQ(Position(two->firstChild(), 2), selection.End());
   EXPECT_EQ(PositionInFlatTree(five->firstChild(), 0),
             selection_in_flat_tree.Start());
   EXPECT_EQ(PositionInFlatTree(five->firstChild(), 2),
             selection_in_flat_tree.End());
 }
 
@@ skipping 20 matching lines @@
   //    <span id="s6">66</span>
   //  </p>
   Element* body = GetDocument().body();
   Element* host = body->QuerySelector("#host");
   Element* one = body->QuerySelector("#one");
   Element* eight = shadow_root2->QuerySelector("#s8");
 
   VisibleSelection selection = CreateVisibleSelection(
       SelectionInDOMTree::Builder()
           .Collapse(Position::FirstPositionInNode(*one))
-          .Extend(Position::LastPositionInNode(shadow_root2))
+          .Extend(Position::LastPositionInNode(*shadow_root2))
           .Build());
   VisibleSelectionInFlatTree selection_in_flat_tree = CreateVisibleSelection(
       SelectionInFlatTree::Builder()
           .Collapse(PositionInFlatTree::FirstPositionInNode(*one))
           .Extend(PositionInFlatTree::AfterNode(*eight))
           .Build());
 
   EXPECT_EQ(Position(host, PositionAnchorType::kBeforeAnchor),
             selection.Start());
   EXPECT_EQ(Position(one->firstChild(), 0), selection.End());
@@ skipping 144 matching lines @@
   Element* host = GetDocument().getElementById("host");
   host->AppendChild(sample);
   GetDocument().UpdateStyleAndLayout();
 
   // Simulates to restore selection from undo stack.
   selection = CreateVisibleSelection(selection.AsSelection());
   EXPECT_EQ(Position(sample->firstChild(), 0), selection.Start());
 }
 
 }  // namespace blink