Make Position::LastPositionInNode() to take const Node& instead of Node*

third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/VisibleUnits.h"
 
 #include <ostream>  // NOLINT
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "core/dom/Text.h"
 #include "core/editing/EditingTestBase.h"
@@ skipping 282 matching lines @@
             actual.inline_box);
 }
 
 // http://crbug.com/716093
 TEST_F(VisibleUnitsTest, ComputeInlineBoxPositionMixedEditable) {
   SetBodyContent(
       "<div contenteditable id=sample>abc<input contenteditable=false></div>");
   Element* const sample = GetDocument().getElementById("sample");
 
   const InlineBoxPosition& actual = ComputeInlineBoxPosition(
-      Position::LastPositionInNode(sample), TextAffinity::kDownstream);
+      Position::LastPositionInNode(*sample), TextAffinity::kDownstream);
   // Should not be in infinite-loop
   EXPECT_EQ(nullptr, actual.inline_box);
   EXPECT_EQ(0, actual.offset_in_box);
 }
 
 TEST_F(VisibleUnitsTest, endOfDocument) {
   const char* body_content = "<a id=host><b id=one>1</b><b id=two>22</b></a>";
   const char* shadow_content =
       "<p><content select=#two></content></p><p><content "
       "select=#one></content></p>";
@@ skipping 919 matching lines @@
 TEST_F(VisibleUnitsTest, mostBackwardCaretPositionAfterAnchor) {
   const char* body_content =
       "<p id='host'><b id='one'>1</b></p><b id='two'>22</b>";
   const char* shadow_content =
       "<b id='two'>22</b><content select=#one></content><b id='three'>333</b>";
   SetBodyContent(body_content);
   SetShadowContent(shadow_content, "host");
 
   Element* host = GetDocument().getElementById("host");
 
-  EXPECT_EQ(Position::LastPositionInNode(host),
+  EXPECT_EQ(Position::LastPositionInNode(*host),
             MostForwardCaretPosition(Position::AfterNode(*host)));
-  EXPECT_EQ(PositionInFlatTree::LastPositionInNode(host),
+  EXPECT_EQ(PositionInFlatTree::LastPositionInNode(*host),
             MostForwardCaretPosition(PositionInFlatTree::AfterNode(*host)));
 }
 
 TEST_F(VisibleUnitsTest, mostBackwardCaretPositionFirstLetter) {
   // Note: first-letter pseudo element contains letter and punctuations.
   const char* body_content =
       "<style>p:first-letter {color:red;}</style><p id=sample> (2)45 </p>";
   SetBodyContent(body_content);
 
   Node* sample = GetDocument().getElementById("sample")->firstChild();
 
   EXPECT_EQ(Position(sample->parentNode(), 0),
             MostBackwardCaretPosition(Position(sample, 0)));
   EXPECT_EQ(Position(sample->parentNode(), 0),
             MostBackwardCaretPosition(Position(sample, 1)));
   EXPECT_EQ(Position(sample, 2),
             MostBackwardCaretPosition(Position(sample, 2)));
   EXPECT_EQ(Position(sample, 3),
             MostBackwardCaretPosition(Position(sample, 3)));
   EXPECT_EQ(Position(sample, 4),
             MostBackwardCaretPosition(Position(sample, 4)));
   EXPECT_EQ(Position(sample, 5),
             MostBackwardCaretPosition(Position(sample, 5)));
   EXPECT_EQ(Position(sample, 6),
             MostBackwardCaretPosition(Position(sample, 6)));
   EXPECT_EQ(Position(sample, 6),
             MostBackwardCaretPosition(Position(sample, 7)));
   EXPECT_EQ(Position(sample, 6),
             MostBackwardCaretPosition(
-                Position::LastPositionInNode(sample->parentNode())));
+                Position::LastPositionInNode(*sample->parentNode())));
   EXPECT_EQ(
       Position(sample, 6),
       MostBackwardCaretPosition(Position::AfterNode(*sample->parentNode())));
-  EXPECT_EQ(Position::LastPositionInNode(GetDocument().body()),
+  EXPECT_EQ(Position::LastPositionInNode(*GetDocument().body()),
             MostBackwardCaretPosition(
-                Position::LastPositionInNode(GetDocument().body())));
+                Position::LastPositionInNode(*GetDocument().body())));
 }
 
 TEST_F(VisibleUnitsTest, mostBackwardCaretPositionFirstLetterSplit) {
   V8TestingScope scope;
 
   const char* body_content =
       "<style>p:first-letter {color:red;}</style><p id=sample>abc</p>";
   SetBodyContent(body_content);
 
   Node* sample = GetDocument().getElementById("sample");
   Node* first_letter = sample->firstChild();
   // Split "abc" into "a" "bc"
   Text* remaining = ToText(first_letter)->splitText(1, ASSERT_NO_EXCEPTION);
   UpdateAllLifecyclePhases();
 
   EXPECT_EQ(Position(sample, 0),
             MostBackwardCaretPosition(Position(first_letter, 0)));
   EXPECT_EQ(Position(first_letter, 1),
             MostBackwardCaretPosition(Position(first_letter, 1)));
   EXPECT_EQ(Position(first_letter, 1),
             MostBackwardCaretPosition(Position(remaining, 0)));
   EXPECT_EQ(Position(remaining, 1),
             MostBackwardCaretPosition(Position(remaining, 1)));
   EXPECT_EQ(Position(remaining, 2),
             MostBackwardCaretPosition(Position(remaining, 2)));
   EXPECT_EQ(Position(remaining, 2),
-            MostBackwardCaretPosition(Position::LastPositionInNode(sample)));
+            MostBackwardCaretPosition(Position::LastPositionInNode(*sample)));
   EXPECT_EQ(Position(remaining, 2),
             MostBackwardCaretPosition(Position::AfterNode(*sample)));
 }
 
 TEST_F(VisibleUnitsTest, mostForwardCaretPositionAfterAnchor) {
   const char* body_content = "<p id='host'><b id='one'>1</b></p>";
   const char* shadow_content =
       "<b id='two'>22</b><content select=#one></content><b id='three'>333</b>";
   SetBodyContent(body_content);
   ShadowRoot* shadow_root = SetShadowContent(shadow_content, "host");
@@ skipping 199 matching lines @@
   const char* body_content = "<p id='sample'>00</p>";
   SetBodyContent(body_content);
   Element* sample = GetDocument().getElementById("sample");
 
   EXPECT_FALSE(RendersInDifferentPosition(Position(), Position()));
   EXPECT_FALSE(
       RendersInDifferentPosition(Position(), Position::AfterNode(*sample)))
       << "if one of position is null, the reuslt is false.";
   EXPECT_FALSE(RendersInDifferentPosition(Position::AfterNode(*sample),
                                           Position(sample, 1)));
-  EXPECT_FALSE(RendersInDifferentPosition(Position::LastPositionInNode(sample),
+  EXPECT_FALSE(RendersInDifferentPosition(Position::LastPositionInNode(*sample),
                                           Position(sample, 1)));
 }
 
 TEST_F(VisibleUnitsTest, rendersInDifferentPositionAfterAnchorWithHidden) {
   const char* body_content =
       "<p><span id=one>11</span><span id=two style='display:none'>  "
       "</span></p>";
   SetBodyContent(body_content);
   Element* one = GetDocument().getElementById("one");
   Element* two = GetDocument().getElementById("two");
 
-  EXPECT_TRUE(RendersInDifferentPosition(Position::LastPositionInNode(one),
+  EXPECT_TRUE(RendersInDifferentPosition(Position::LastPositionInNode(*one),
                                          Position(two, 0)))
       << "two doesn't have layout object";
 }
 
 TEST_F(VisibleUnitsTest,
        rendersInDifferentPositionAfterAnchorWithDifferentLayoutObjects) {
   const char* body_content =
       "<p><span id=one>11</span><span id=two>  </span></p>";
   SetBodyContent(body_content);
   Element* one = GetDocument().getElementById("one");
   Element* two = GetDocument().getElementById("two");
 
-  EXPECT_FALSE(RendersInDifferentPosition(Position::LastPositionInNode(one),
+  EXPECT_FALSE(RendersInDifferentPosition(Position::LastPositionInNode(*one),
                                           Position(two, 0)));
-  EXPECT_FALSE(RendersInDifferentPosition(Position::LastPositionInNode(one),
+  EXPECT_FALSE(RendersInDifferentPosition(Position::LastPositionInNode(*one),
                                           Position(two, 1)))
       << "width of two is zero since contents is collapsed whitespaces";
 }
 
 TEST_F(VisibleUnitsTest, renderedOffset) {
   const char* body_content =
       "<div contenteditable><span id='sample1'>1</span><span "
       "id='sample2'>22</span></div>";
   SetBodyContent(body_content);
   Element* sample1 = GetDocument().getElementById("sample1");
   Element* sample2 = GetDocument().getElementById("sample2");
 
   EXPECT_FALSE(
       RendersInDifferentPosition(Position::AfterNode(*sample1->firstChild()),
                                  Position(sample2->firstChild(), 0)));
   EXPECT_FALSE(RendersInDifferentPosition(
-      Position::LastPositionInNode(sample1->firstChild()),
+      Position::LastPositionInNode(*sample1->firstChild()),
       Position(sample2->firstChild(), 0)));
 }
 
 TEST_F(VisibleUnitsTest, startOfDocument) {
   const char* body_content = "<a id=host><b id=one>1</b><b id=two>22</b></a>";
   const char* shadow_content =
       "<p><content select=#two></content></p><p><content "
       "select=#one></content></p>";
   SetBodyContent(body_content);
   SetShadowContent(shadow_content, "host");
@@ skipping 329 matching lines @@
 TEST_F(VisibleUnitsTest,
        PreviousRootInlineBoxCandidatePositionWithDisplayNone) {
   SetBodyContent(
       "<div contenteditable>"
       "<div id=one>one abc</div>"
       "<div id=two>two <b id=none style=display:none>def</b> ghi</div>"
       "</div>");
   Element* const one = GetDocument().getElementById("one");
   Element* const two = GetDocument().getElementById("two");
   const VisiblePosition& visible_position =
-      CreateVisiblePosition(Position::LastPositionInNode(two));
+      CreateVisiblePosition(Position::LastPositionInNode(*two));
   EXPECT_EQ(Position(one->firstChild(), 7),
             PreviousRootInlineBoxCandidatePosition(
                 two->lastChild(), visible_position, kContentIsEditable));
 }
 
 }  // namespace blink