Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: third_party/WebKit/Source/core/editing/SurroundingText.cpp

Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-26T14:00:00 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SurroundingText.cpp
diff --git a/third_party/WebKit/Source/core/editing/SurroundingText.cpp b/third_party/WebKit/Source/core/editing/SurroundingText.cpp
index 7e9926dd7e6693f3bf58d8d0f66d208bcc7ee036..a4db50ce882c9ef697ab2b754c5edf6f876b7f16 100644
--- a/third_party/WebKit/Source/core/editing/SurroundingText.cpp
+++ b/third_party/WebKit/Source/core/editing/SurroundingText.cpp
@@ -74,7 +74,7 @@ void SurroundingText::Initialize(const Position& start_position,
CharacterIterator forward_iterator(
end_position,
- Position::LastPositionInNode(root_element).ParentAnchoredEquivalent(),
+ Position::LastPositionInNode(*root_element).ParentAnchoredEquivalent(),
TextIteratorBehavior::Builder().SetStopsOnFormControls(true).Build());
// FIXME: why do we stop going trough the text if we were not able to select
// something on the right?
« no previous file with comments | « third_party/WebKit/Source/core/editing/PositionTest.cpp ('k') | third_party/WebKit/Source/core/editing/TextFinder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698