Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: third_party/WebKit/Source/core/editing/Position.cpp

Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-26T14:00:00 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Position.cpp
diff --git a/third_party/WebKit/Source/core/editing/Position.cpp b/third_party/WebKit/Source/core/editing/Position.cpp
index bb52336e1a4fce1d217022f30dda249de800dfb2..0026b598d9d044ce30d183f9856e33120dad114e 100644
--- a/third_party/WebKit/Source/core/editing/Position.cpp
+++ b/third_party/WebKit/Source/core/editing/Position.cpp
@@ -500,12 +500,12 @@ PositionTemplate<Strategy> PositionTemplate<Strategy>::FirstPositionInNode(
// static
template <typename Strategy>
PositionTemplate<Strategy> PositionTemplate<Strategy>::LastPositionInNode(
- Node* anchor_node) {
- if (anchor_node->IsTextNode()) {
+ const Node& anchor_node) {
+ if (anchor_node.IsTextNode()) {
return PositionTemplate<Strategy>(anchor_node,
- LastOffsetInNode(*anchor_node));
+ LastOffsetInNode(anchor_node));
}
- return PositionTemplate<Strategy>(anchor_node,
+ return PositionTemplate<Strategy>(&anchor_node,
PositionAnchorType::kAfterChildren);
}
@@ -526,7 +526,7 @@ PositionTemplate<Strategy>::LastPositionInOrAfterNode(Node* node) {
if (!node)
return PositionTemplate<Strategy>();
return EditingIgnoresContent(*node) ? AfterNode(*node)
- : LastPositionInNode(node);
+ : LastPositionInNode(*node);
}
PositionInFlatTree ToPositionInFlatTree(const Position& pos) {
« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.h ('k') | third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698