third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp - Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-26T14:00:00 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

index a2d4f001a8c433b1e2b2d84e670dfe44fa174339..e0217d2ff05f319c813091a071dcd5038ddcb39f 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

@@ -335,7 +335,7 @@ void ApplyBlockElementCommand::RangeForParagraphSplittingTextNodesIfNeeded(

end_container, end_of_last_paragraph.OffsetInContainerNode() -

end.OffsetInContainerNode());

}

- end = Position::LastPositionInNode(end_container->previousSibling());

+ end = Position::LastPositionInNode(*end_container->previousSibling());

}