third_party/WebKit/Source/core/editing/TextFinder.cpp - Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/TextFinder.cpp

Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-26T14:00:00 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/TextFinder.cpp

diff --git a/third_party/WebKit/Source/core/editing/TextFinder.cpp b/third_party/WebKit/Source/core/editing/TextFinder.cpp

index 0cc56281e31252f72204e4d860bbe2fcbb461951..7fb05c695fb662eaf70ac72b49d3eb07d278f16f 100644

--- a/third_party/WebKit/Source/core/editing/TextFinder.cpp

+++ b/third_party/WebKit/Source/core/editing/TextFinder.cpp

@@ -397,7 +397,7 @@ void TextFinder::ScopeStringMatches(int identifier,

PositionInFlatTree search_start = PositionInFlatTree::FirstPositionInNode(

*OwnerFrame().GetFrame()->GetDocument());

PositionInFlatTree search_end = PositionInFlatTree::LastPositionInNode(

- OwnerFrame().GetFrame()->GetDocument());

+ *OwnerFrame().GetFrame()->GetDocument());

DCHECK_EQ(search_start.GetDocument(), search_end.GetDocument());

if (resume_scoping_from_range_) {