Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 23576015: Change old PRG to be SkLCGRandom; change new one to SkRandom (Closed)

Created:
7 years, 3 months ago by jvanverth1
Modified:
7 years, 3 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Change old PRG to be SkLCGRandom; change new one to SkRandom The goal here is to get people to start using the new random number generator, while leaving the old one in place so we don't have to rebaseline GMs. Committed: http://code.google.com/p/skia/source/detail?r=11169

Patch Set 1 #

Patch Set 2 : Fix some spacing #

Patch Set 3 : Rebase to HEAD #

Patch Set 4 : Fix some spurious SkMWCRandoms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2761 lines, -2761 lines) Patch
M bench/AAClipBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/BicubicBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapRectBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/BlurBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/ChartBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/ChecksumBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/FSRectBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GameBench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M bench/GrMemoryPoolBench.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M bench/HairlinePathBench.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M bench/LineBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/MathBench.cpp View 1 2 7 chunks +7 lines, -7 lines 0 comments Download
M bench/MatrixBench.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M bench/MatrixConvolutionBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/MorphologyBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/PathBench.cpp View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M bench/PathIterBench.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M bench/PathUtilsBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/PictureRecordBench.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M bench/RTreeBench.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M bench/RectBench.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M bench/RectoriBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/RegionBench.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M bench/RegionContainBench.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M bench/ScalarBench.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M bench/ShaderMaskBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/SortBench.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M bench/TextBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/VertBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/XfermodeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/arcofzorro.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/beziereffects.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/circles.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M gm/complexclip2.cpp View 1 chunk +182 lines, -182 lines 0 comments Download
M gm/convexpaths.cpp View 1 chunk +297 lines, -297 lines 0 comments Download
M gm/cubicpaths.cpp View 1 chunk +344 lines, -344 lines 0 comments Download
M gm/degeneratesegments.cpp View 1 chunk +400 lines, -400 lines 0 comments Download
M gm/emptypath.cpp View 1 chunk +133 lines, -133 lines 0 comments Download
M gm/getpostextpath.cpp View 1 chunk +73 lines, -73 lines 0 comments Download
M gm/hittestpath.cpp View 1 chunk +75 lines, -75 lines 0 comments Download
M gm/linepaths.cpp View 1 chunk +305 lines, -305 lines 0 comments Download
M gm/mixedxfermodes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/nested.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/ovals.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/points.cpp View 1 chunk +73 lines, -73 lines 0 comments Download
M gm/quadpaths.cpp View 1 chunk +307 lines, -307 lines 0 comments Download
M gm/roundrects.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/strokerects.cpp View 1 chunk +83 lines, -83 lines 0 comments Download
M gm/strokes.cpp View 1 chunk +250 lines, -250 lines 0 comments Download
M include/gpu/GrEffectUnitTest.h View 5 chunks +6 lines, -6 lines 0 comments Download
M include/utils/SkRandom.h View 3 chunks +10 lines, -10 lines 0 comments Download
M samplecode/SampleAnimBlur.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleChart.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleClip.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M samplecode/SampleCull.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleEmptyPath.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFontCache.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleHairCurves.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleManyRects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePathEffects.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePicture.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePoints.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleRotateCircles.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleSlides.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleStrokePath.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleText.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleTextAlpha.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleVertices.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFloat.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBitmapAlphaThresholdShader.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDiscretePathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrRedBlackTree.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkPathUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/AAClipTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/BitmapGetColorTest.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tests/ClampRangeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClipStackTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ColorFilterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ColorTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GrMemoryPoolTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/InfRectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/LListTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/MathTest.cpp View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M tests/MatrixTest.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M tests/MipMapTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PackBitsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PaintTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/PathTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/PathUtilsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/RTreeTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/RandomTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/RegionTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/Sk64Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SortTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/UtilsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Writer32Test.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jvanverth1
I'm sorry: There are a lot of files. But basically this boils down to: - ...
7 years, 3 months ago (2013-09-05 20:24:31 UTC) #1
reed1
lgtm
7 years, 3 months ago (2013-09-05 20:25:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/23576015/3001
7 years, 3 months ago (2013-09-09 15:23:37 UTC) #3
commit-bot: I haz the power
Failed to apply patch for gm/circles.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-09 15:24:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/23576015/8001
7 years, 3 months ago (2013-09-09 15:48:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildGm, BuildSkiaLib, BuildTests, BuildTools http://173.255.115.253:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=567
7 years, 3 months ago (2013-09-09 15:57:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/23576015/41001
7 years, 3 months ago (2013-09-09 16:18:08 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 20:10:12 UTC) #8
Message was sent while issue was closed.
Change committed as 11169

Powered by Google App Engine
This is Rietveld 408576698