Refactor NumericBuilder to HistogramBinBoundaries.

Refactor NumericBuilder to HistogramBinBoundaries.

HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.

The Histogram constructor now takes a unit and an optional HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the larger Histogram concept.

Metrics are all changed to say |new Histogram(unit, boundaries)|.

cpu_process_metric was incorrectly producing percentages between 0 and 100,
and was changed to 0 to 1.

BUG=catapult:#2685

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/17bda7618b6d6dd0814e494d762f20e85bc3fed0

[benjhayden, 2016-08-29 16:11:09]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org

[benjhayden, 2016-08-29 16:11:10]

PTAL :-)

[benjhayden, 2016-08-29 16:11:52]

Description was changed from

==========
Rename NumericBuilder to HistogramBuilder.

Next step: refactor HistogramBuilder so that it only builds binBounds so that
metrics can finally say 'new Histogram(..., SHAPE_OF_EVENT_COUNT_DISTRIBUTION)'

BUG=catapult:#2685
==========

to

==========
Rename NumericBuilder to HistogramBuilder.

Next step: refactor HistogramBuilder so that it only builds binBounds so that
metrics can finally say 'new Histogram(..., SHAPE_OF_METRIC_DISTRIBUTION)'

BUG=catapult:#2685
==========

[benjhayden, 2016-08-29 16:12:03]

Description was changed from

==========
Rename NumericBuilder to HistogramBuilder.

Next step: refactor HistogramBuilder so that it only builds binBounds so that
metrics can finally say 'new Histogram(..., SHAPE_OF_METRIC_DISTRIBUTION)'

BUG=catapult:#2685
==========

to

==========
Rename NumericBuilder to HistogramBuilder.

Next step: refactor HistogramBuilder so that it only builds binBounds so that
metrics can say 'new Histogram(..., SHAPE_OF_METRIC_DISTRIBUTION)'

BUG=catapult:#2685
==========

[benjhayden, 2016-08-29 17:51:26]

Hold review. I'll go ahead and make this CL do the HistogramBinBounds refactor
that we discussed.

[benjhayden, 2016-08-29 20:03:48]

Description was changed from

==========
Rename NumericBuilder to HistogramBuilder.

Next step: refactor HistogramBuilder so that it only builds binBounds so that
metrics can say 'new Histogram(..., SHAPE_OF_METRIC_DISTRIBUTION)'

BUG=catapult:#2685
==========

to

==========
Refactor NumericBuilder to HistogramBinBoundaries.

HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.

The Histogram constructor now takes a unit and an optional
HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to
Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the broader Histogram concept.

BUG=catapult:#2685
==========

[benjhayden, 2016-08-29 23:50:07]

Description was changed from

==========
Refactor NumericBuilder to HistogramBinBoundaries.

HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.

The Histogram constructor now takes a unit and an optional
HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to
Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the broader Histogram concept.

BUG=catapult:#2685
==========

to

==========
Refactor NumericBuilder to HistogramBinBoundaries.

HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.

The Histogram constructor now takes a unit and an optional
HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to
Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the larger Histogram concept.

BUG=catapult:#2685
==========

[benjhayden, 2016-08-29 23:50:43]

Description was changed from

==========
Refactor NumericBuilder to HistogramBinBoundaries.

HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.

The Histogram constructor now takes a unit and an optional
HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to
Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the larger Histogram concept.

BUG=catapult:#2685
==========

to

==========
Refactor NumericBuilder to HistogramBinBoundaries.

HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.

The Histogram constructor now takes a unit and an optional
HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to
Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the larger Histogram concept.

Metrics are all changed to say |new Histogram(unit, boundaries)|.

BUG=catapult:#2685
==========

[benjhayden, 2016-08-29 23:58:10]

Description was changed from

==========
Refactor NumericBuilder to HistogramBinBoundaries.

HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.

The Histogram constructor now takes a unit and an optional
HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to
Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the larger Histogram concept.

Metrics are all changed to say |new Histogram(unit, boundaries)|.

BUG=catapult:#2685
==========

to

==========
Refactor NumericBuilder to HistogramBinBoundaries.

HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.

The Histogram constructor now takes a unit and an optional
HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to
Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the larger Histogram concept.

Metrics are all changed to say |new Histogram(unit, boundaries)|.

cpu_process_metric was incorrectly producing percentages between 0 and 100,
and was changed to 0 to 1.

BUG=catapult:#2685
==========

[benjhayden, 2016-08-30 00:19:36]

OK, ready. PTAL :-)

[eakuefner, 2016-08-30 18:04:51]

lgtm

[benjhayden, 2016-08-30 18:06:50]

I'll move dots back to the next lines.

[benjhayden, 2016-08-30 18:22:24]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-08-30 18:22:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2293533002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-30 18:22:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:07:11]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[benjhayden, 2016-08-30 20:59:17]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-08-30 20:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2293533002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-30 20:59:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 21:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:51:10]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[benjhayden, 2016-08-30 22:12:36]

benjhayden@chromium.org changed reviewers:
+ oysteine@chromium.org

[benjhayden, 2016-08-30 22:12:37]

oysteine: stamp for trace_processor ownership please? :-)

[oystein (OOO til 10th of July), 2016-08-30 22:29:13]

lgtm

[benjhayden, 2016-08-30 23:21:51]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2016-08-30 23:21:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 23:27:22]

Description was changed from

==========
Refactor NumericBuilder to HistogramBinBoundaries.

HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.

The Histogram constructor now takes a unit and an optional
HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to
Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the larger Histogram concept.

Metrics are all changed to say |new Histogram(unit, boundaries)|.

cpu_process_metric was incorrectly producing percentages between 0 and 100,
and was changed to 0 to 1.

BUG=catapult:#2685
==========

to

==========
Refactor NumericBuilder to HistogramBinBoundaries.

HistogramBinBoundaries still allows metrics to use the builder pattern,
but it's building only the bin boundaries, not the entire Histogram object.

The Histogram constructor now takes a unit and an optional
HistogramBinBoundaries
object. Soon, Histogram will subsume name from Value, but that's it.
2 or 3 arguments is not enough to warrant applying the builder pattern to
Histogram
construction.
HistogramBinBoundaries *are* complex enough to warrant the builder pattern, but
they are separate from the larger Histogram concept.

Metrics are all changed to say |new Histogram(unit, boundaries)|.

cpu_process_metric was incorrectly producing percentages between 0 and 100,
and was changed to 0 to 1.

BUG=catapult:#2685

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-08-30 23:27:23]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...