Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: tracing/tracing/value/ui/value_set_table_test.html

Issue 2293533002: Refactor NumericBuilder to HistogramBinBoundaries. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/ui/scalar_span_test.html ('k') | tracing/tracing/value/ui/value_set_view_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/value_set_table_test.html
diff --git a/tracing/tracing/value/ui/value_set_table_test.html b/tracing/tracing/value/ui/value_set_table_test.html
index 9cb95d5842af0551ff11bdc8a65d52d932b97746..a23cf6036a96581bf2b313cf749b8a195f3d12a3 100644
--- a/tracing/tracing/value/ui/value_set_table_test.html
+++ b/tracing/tracing/value/ui/value_set_table_test.html
@@ -15,9 +15,7 @@ found in the LICENSE file.
'use strict';
tr.b.unittest.testSuite(function() {
- var TEST_NUMERIC_BUILDER = tr.v.NumericBuilder.createLinear(
- tr.v.Unit.byName.timeDurationInMs_smallerIsBetter,
- tr.b.Range.fromExplicitRange(0, 1000), 20);
+ var TEST_BOUNDARIES = tr.v.HistogramBinBoundaries.createLinear(0, 1e3, 20);
function getTableRowAtPath(table, path) {
var row = table.tableRows[0];
@@ -29,7 +27,8 @@ tr.b.unittest.testSuite(function() {
test('instantiate_1x1', function() {
var table = document.createElement('tr-v-ui-value-set-table');
var values = new tr.v.ValueSet();
- var numeric = TEST_NUMERIC_BUILDER.build();
+ var numeric = new tr.v.Histogram(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, TEST_BOUNDARIES);
for (var i = 0; i < 100; ++i)
numeric.add(Math.random() * 1000);
values.addValue(new tr.v.NumericValue('foo', numeric));
@@ -47,7 +46,8 @@ tr.b.unittest.testSuite(function() {
var table = document.createElement('tr-v-ui-value-set-table');
var values = new tr.v.ValueSet();
- var numeric0a = TEST_NUMERIC_BUILDER.build();
+ var numeric0a = new tr.v.Histogram(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, TEST_BOUNDARIES);
for (var i = 0; i < 100; ++i)
numeric0a.add(Math.random() * 1000);
var fooA = new tr.v.NumericValue('foo', numeric0a, {
@@ -59,7 +59,8 @@ tr.b.unittest.testSuite(function() {
benchmarkStartMs: new Date().getTime(),
}).addToValue(fooA);
- var numeric1a = TEST_NUMERIC_BUILDER.build();
+ var numeric1a = new tr.v.Histogram(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, TEST_BOUNDARIES);
for (var i = 0; i < 100; ++i)
numeric1a.add(Math.random() * 1000);
var barA = new tr.v.NumericValue('bar', numeric1a, {
@@ -71,7 +72,8 @@ tr.b.unittest.testSuite(function() {
benchmarkStartMs: new Date().getTime(),
}).addToValue(barA);
- var numeric0b = TEST_NUMERIC_BUILDER.build();
+ var numeric0b = new tr.v.Histogram(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, TEST_BOUNDARIES);
for (var i = 0; i < 100; ++i)
numeric0b.add(Math.random() * 1000);
var fooB = new tr.v.NumericValue('foo', numeric0b, {
@@ -83,7 +85,8 @@ tr.b.unittest.testSuite(function() {
benchmarkStartMs: new Date().getTime(),
}).addToValue(fooB);
- var numeric1b = TEST_NUMERIC_BUILDER.build();
+ var numeric1b = new tr.v.Histogram(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter, TEST_BOUNDARIES);
for (var i = 0; i < 100; ++i)
numeric1b.add(Math.random() * 1000);
var barB = new tr.v.NumericValue('bar', numeric1b, {
@@ -127,7 +130,9 @@ tr.b.unittest.testSuite(function() {
++storysetCounter) {
for (var storyCounter = 0; storyCounter < 2; ++storyCounter) {
for (var label of labels) {
- var numeric = TEST_NUMERIC_BUILDER.build();
+ var numeric = new tr.v.Histogram(
+ tr.v.Unit.byName.timeDurationInMs_smallerIsBetter,
+ TEST_BOUNDARIES);
for (var i = 0; i < 100; ++i)
numeric.add(Math.random() * 1000);
« no previous file with comments | « tracing/tracing/value/ui/scalar_span_test.html ('k') | tracing/tracing/value/ui/value_set_view_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698